fix(popup): misalignment in popup close button icon #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #575
Closes argoproj/argo-cd#19372
Hello,
While I was working on fixing a UI issue, I noticed that the popup had a close button icon alignment problem.
However, according to PR #575, this misalignment was already fixed. It seems that the button, which was previously positioned lower, was moved up in that PR. I'm not sure when it happened, but it seems that the button was moved up again.
Still, my Argo CD instance shows the issue, as you can see, so I fixed it to ensure the icon is properly positioned.
I tried both Edge and Chrome, but it doesn’t seem to be a browser issue.
Before
After
Please check it out and let me know if this problem only occurs in my UI. I’ve attached screenshots of my UI.
Thanks!