fix(controller): allowing abort during a full promotion Fixes #4461

[antonioazambuja]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

Summary

• Fixes issue Argo Rollouts controller does not abort the canary revision when it already has a full promotion request #4461. During a full promotion, the canary won't be aborted.
• Impact: Services with a full promotion request can not be aborted.

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 32m 38s ⏱️
118 tests 107 ✅  7 💤 4 ❌
478 runs  444 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit fc7394f.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 354 tests   2 354 ✅  3m 2s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit fc7394f.

♻️ This comment has been updated with latest results.

[Copilot]

Pull Request Overview

Fixes an issue where canary rollouts cannot be aborted after a full promotion is requested. The bug prevented the abort command from taking effect when PromoteFull is true, causing canary pods to remain at full weight instead of scaling down to zero during an abort.

• Modified abort logic to check abort status before applying full promotion weight
• Added condition to only remove abort during rollback scenarios, not full promotion
• Added comprehensive test coverage for the abort after full promotion scenario

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
utils/replicaset/canary.go	Modified weight calculation to respect abort status even during full promotion
rollout/canary.go	Updated abort removal logic to only apply during rollback, preserving abort during full promotion
utils/replicaset/canary_test.go	Added test cases for abort scenarios during full promotion
test/e2e/functional_test.go	Added end-to-end test for abort after full promotion and removed conflicting abort call

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Missing period after the first ExpectRevisionPodCount call - should be .ExpectRevisionPodCount("1", 4). to maintain consistent method chaining.

Suggested change

	ExpectRevisionPodCount("2", 0)
	ExpectRevisionPodCount("2", 0)

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
25.0% Duplication on New Code

See analysis details on SonarQube Cloud