Skip to content

Conversation

@cokeeffe
Copy link

@cokeeffe cokeeffe commented Sep 18, 2025

In order to be able to use metadata from Analysis jobs (specifically in Kargo), we need allow valueFrom.fieldRef.fieldPath lookups in the spec.args

For example, use get the verification AnalysisRun name from the job pod:

apiVersion: argoproj.io/v1alpha1
kind: AnalysisTemplate
...
spec:
  args:
    - name: verificationRunName
      valueFrom:
        fieldRef:
          fieldPath: metadata.name
  metrics:
    - name: integration-test
      provider:
        job:
          spec:
            backoffLimit: 1
            template:
              spec:
                containers:
                    env:
                      - name: RESOURCE_NAME
                        value: ${{ args.verificationRunName }}

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@cokeeffe cokeeffe changed the title Add support for valueFrom.FieldRef.fieldPath in AnalysisTemplate run arguments Fix: Add support for valueFrom.FieldRef.fieldPath in AnalysisTemplate run arguments Sep 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

Published E2E Test Results

  4 files    4 suites   3h 53m 6s ⏱️
115 tests 104 ✅  7 💤  4 ❌
482 runs  430 ✅ 28 💤 24 ❌

For more details on these failures, see this check.

Results for commit 49355f4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

Published Unit Test Results

2 338 tests   2 338 ✅  3m 1s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 49355f4.

♻️ This comment has been updated with latest results.

@cokeeffe cokeeffe changed the title Fix: Add support for valueFrom.FieldRef.fieldPath in AnalysisTemplate run arguments fix: Add support for valueFrom.FieldRef.fieldPath in AnalysisTemplate run arguments Sep 18, 2025
Signed-off-by: Colin O'Keeffe <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant