Repository navigation
Conversation
Signed-off-by: Ke Li <77185597+kkli08@users.noreply.github.com>
kkli08
requested review from
Le8r0nJames,
garrett4wade,
geshi001,
nuzant,
rchardx and
sitabulaixizawaluduo
as code owners
September 3, 2026 02:10
Author
|
Thanks @HT-Yuan and @sitabulaixizawaluduo. I’ve opened this focused follow-up as discussed. It adds correct gradient isolation for distinct and repeated multi-depth MTP on top of #1659, with exact-gradient tests. Broader Qwen3.5 GDN + MTP + CP support remains separate. |
Collaborator
Can you provide a truly verified training curve to demonstrate the effectiveness of the current precision-recall? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked follow-up to #1659.
For multi-depth MTP, detaching
hidden_statesat every prediction depth prevents deeper auxiliary losses from updating earlier MTP blocks. This change:Related Issue
Related PR: #1659
Type of Change
Checklist
pre-commit run --all-files)main(this PR intentionally targets feat: add MTP training with speculative decoding rollout #1659's feature branch)/review-prcommandValidation
git diff --checkpassed.The SGD check intentionally does not claim production optimizer-step equivalence: global gradient clipping can couple updates through the overall gradient norm. CUDA/Transformer Engine, PP/VPP, and distributed-optimizer execution remain for CI/GPU validation.