Repository navigation
test: restore skipped CPU coverage - #1655
Merged
HwVanICI merged 1 commit intoAug 31, 2026
Merged
Conversation
Update stale LocalScheduler fixtures and trajectory export expectations so the CPU gate exercises them again. Isolate Megatron async-save stubs from modules cached by earlier tests. Key changes: - Provide current scheduling specs for LocalScheduler jobs - Validate serialized trajectory payloads in inference-service tests - Remove async-save import-order and fixture skips
Adiactive
requested review from
garrett4wade and
sitabulaixizawaluduo
as code owners
August 31, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore 100 CPU test cases that were unconditionally skipped because of stale LocalScheduler fixtures, cached Megatron test stubs, and legacy inference-service trajectory export assertions. This is test-only and does not change production or workflow behavior.
Related Issue
N/A
Type of Change
Checklist
pre-commit run --all-files)ascend/review-prcommand/create-prBreaking Change Details (if applicable):
N/A
Additional Context
The LocalScheduler suite now supplies the required
SchedulingSpecfields and all 91 cases pass. The Megatron async-save fixture restores cached modules after its isolated stubs, allowing both previously skipped metric cases to run regardless of test order. Seven inference-service tests now validate the serializedtrajresponse and distinguish explicit from latest trajectory selection using request-token markers. Validation: 105 recovered cases passed together in 88.28 seconds; the four affected inference-service files produced 128 passes locally, and their four existing callback tests passed separately with local proxy bypass; full pre-commit passed. Based on the latest Ascend CPU report, expected results change from 2,321 passed and 111 skipped to 2,421 passed and 11 skipped, with 2,432 selected cases unchanged.Need help? Check the Contributing Guide or ask in GitHub Discussions!