Skip to content

Update NTPClient.h#208

Open
drovosekov wants to merge 4 commits intoarduino-libraries:masterfrom
drovosekov:patch-2
Open

Update NTPClient.h#208
drovosekov wants to merge 4 commits intoarduino-libraries:masterfrom
drovosekov:patch-2

Conversation

@drovosekov
Copy link
Copy Markdown

add getDate(), getMonth(), getYear(), getFullFormattedTime(), and getTM_t()

add getDate(), getMonth(), getYear(), getFullFormattedTime(),  
and getTM_t()
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2024

Memory usage change @ cf242bb

Board flash % RAM for global variables %
esp8266:esp8266:huzzah N/A N/A N/A N/A
Click for full report table
Board examples/Advanced
flash
% examples/Advanced
RAM for global variables
% examples/Basic
flash
% examples/Basic
RAM for global variables
% examples/IsTimeSet
flash
% examples/IsTimeSet
RAM for global variables
%
esp8266:esp8266:huzzah N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/IsTimeSet<br>flash,%,examples/IsTimeSet<br>RAM for global variables,%
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 23, 2024
Copy link
Copy Markdown
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drovosekov. Thanks for taking the time to submit a pull request.

The pull request must contain your complete proposal, but the proposed changes to NTPClient.cpp are missing from this pull request. I see you submitted them in a separate pull request (#209), but that is not allowed.

Please add the proposed NTPClient.cpp to this pull request. You can do that by editing the file in the patch-2 branch of your fork and then committing the change to that branch. Any commits you push to the patch-2 will automatically be added to this pull request.

@per1234 per1234 mentioned this pull request Jun 23, 2024
@per1234 per1234 dismissed their stale review June 23, 2024 20:13

Requested change was made

@drovosekov
Copy link
Copy Markdown
Author

Hi @per1234,
I have updated the patch-2
A feature has also been added to update the config NTPClient during code runtime.

@github-actions
Copy link
Copy Markdown

Memory usage change @ 017a61b

Board flash % RAM for global variables %
esp8266:esp8266:huzzah N/A N/A N/A N/A
Click for full report table
Board examples/Advanced
flash
% examples/Advanced
RAM for global variables
% examples/Basic
flash
% examples/Basic
RAM for global variables
% examples/IsTimeSet
flash
% examples/IsTimeSet
RAM for global variables
%
esp8266:esp8266:huzzah N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV
Board,examples/Advanced<br>flash,%,examples/Advanced<br>RAM for global variables,%,examples/Basic<br>flash,%,examples/Basic<br>RAM for global variables,%,examples/IsTimeSet<br>flash,%,examples/IsTimeSet<br>RAM for global variables,%
esp8266:esp8266:huzzah,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@drovosekov drovosekov closed this Jun 26, 2024
@drovosekov drovosekov reopened this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getFormattedTime does not give date+time string

3 participants