Skip to content

chore: selfSigned on console web#1286

Merged
ChiragAgg5k merged 1 commit intomasterfrom
console-web-selfsigned
Jan 2, 2026
Merged

chore: selfSigned on console web#1286
ChiragAgg5k merged 1 commit intomasterfrom
console-web-selfsigned

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Jan 2, 2026

Summary by CodeRabbit

Release Notes

  • New Features
    • SDK configuration now supports platform overrides, enabling more flexible setup for web environments.
    • Console platform deployments can now configure self-signed certificate support through a new configuration option.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 2, 2026

Walkthrough

The changes add platform-specific configuration capabilities to an SDK implementation. In example.php, the code now handles platform overrides by invoking setPlatform when a platform is provided in configuration. In templates/web/src/client.ts.twig, a new selfSigned boolean configuration property is introduced to the Client class, along with a corresponding setSelfSigned method. These additions are conditionally applied only when the console platform is active. The Client.config type signature is also expanded to accept boolean values in addition to strings for dynamic keys.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: selfSigned on console web' accurately describes the main change: adding selfSigned configuration support for the console web platform.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33e0473 and 1af2063.

📒 Files selected for processing (2)
  • example.php
  • templates/web/src/client.ts.twig
🧰 Additional context used
🧬 Code graph analysis (1)
example.php (1)
src/SDK/SDK.php (1)
  • setPlatform (303-308)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: swift (server)
  • GitHub Check: android (client)
  • GitHub Check: flutter (client)
  • GitHub Check: apple (client)
  • GitHub Check: build (8.3, Python313)
  • GitHub Check: build (8.3, WebChromium)
  • GitHub Check: build (8.3, Node16)
  • GitHub Check: build (8.3, Node18)
  • GitHub Check: build (8.3, AppleSwift56)
  • GitHub Check: build (8.3, KotlinJava17)
  • GitHub Check: build (8.3, Go118)
  • GitHub Check: build (8.3, Python312)
  • GitHub Check: build (8.3, KotlinJava8)
  • GitHub Check: build (8.3, FlutterBeta)
  • GitHub Check: build (8.3, CLINode20)
  • GitHub Check: build (8.3, FlutterStable)
  • GitHub Check: build (8.3, Android14Java17)
  • GitHub Check: build (8.3, Android5Java17)
🔇 Additional comments (5)
example.php (2)

82-84: LGTM! Consistent configuration pattern.

The platform configuration support follows the established pattern used for namespace and exclude overrides. The conditional check safely handles cases where platform is not provided.


126-126: LGTM! Platform-specific configuration for Web SDK.

Passing the platform override specifically to the Web SDK generation enables console platform support, which aligns with the conditional selfSigned configuration added in templates/web/src/client.ts.twig.

templates/web/src/client.ts.twig (3)

306-315: LGTM! Console-specific configuration properly scoped.

The selfSigned property is correctly:

  • Typed as boolean in the config interface
  • Initialized to false (safe default)
  • Scoped to console platform only via template conditionals

The index signature widening to include boolean on line 309 is necessary to accommodate the selfSigned property while maintaining TypeScript type safety.


377-390: LGTM! Setter method follows established patterns.

The setSelfSigned method correctly:

  • Follows the builder pattern used by other setters
  • Provides appropriate JSDoc documentation
  • Is properly scoped to console platform only

306-315: The selfSigned property in the web SDK cannot be used due to browser limitations.

The property is defined and has a setter method, but it has no effect in the browser because JavaScript cannot programmatically disable SSL certificate validation—this is a browser security restriction. The property exists for API consistency with other SDK platforms (Node.js, PHP, Swift, etc.) where selfSigned is actively used for server-side/native certificate handling. For the web SDK, this property is informational only and cannot be implemented.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChiragAgg5k ChiragAgg5k merged commit a4fae2f into master Jan 2, 2026
53 checks passed
@ChiragAgg5k ChiragAgg5k deleted the console-web-selfsigned branch January 2, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants