refactor!: Rewrite the FilesystemStorageClient to use apify/crawlee-storage#3762
Open
janbuchar wants to merge 19 commits into
Open
refactor!: Rewrite the FilesystemStorageClient to use apify/crawlee-storage#3762janbuchar wants to merge 19 commits into
janbuchar wants to merge 19 commits into
Conversation
janbuchar
commented
Jun 18, 2026
janbuchar
commented
Contributor
- closes Use apify/crawlee-storage to implement a filesystem-backed storage client #3735
janbuchar
added
the
t-tooling
janbuchar
commented
Jun 25, 2026
| // The native iterator handles `prefix`, `exclusiveStartKey`, and `limit`, but it neither throws | ||
| // for an unknown `exclusiveStartKey` nor sees untracked value files on disk ("bare files"). We | ||
| // add both behaviors here. | ||
| const bareFiles = await this.listBareFiles(); |
Contributor
Author
There was a problem hiding this comment.
I will try to push this down to the native client, so the method might become obsolete soon.
janbuchar
requested review from
B4nan,
barjin and
vladfrangu
and removed request for
B4nan,
barjin and
vladfrangu
Contributor
Author
|
@vladfrangu this touches a guide you wrote, please make sure I didn't ruin it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.