Skip to content

test: deflake request queue fetch-and-handle integration tests #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Jun 17, 2026
+18 −12
Merged

test: deflake request queue fetch-and-handle integration tests #991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions tests/integration/test_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@ async def test_add_and_fetch_requests(
Actor.log.info('Fetching next request...')
queue_operation_info = await rq.mark_request_as_handled(next_request)
assert queue_operation_info is not None, f'queue_operation_info={queue_operation_info}'
assert queue_operation_info.was_already_handled is False, (
f'queue_operation_info.was_already_handled={queue_operation_info.was_already_handled}'
)
handled_request_count += 1
# The request queue has at-least-once delivery: a request can occasionally be fetched again before the
# platform propagates its handled state, so the same request may be marked as handled more than once
# (`was_already_handled` reports the state before this update). Count only the first time each request is
# handled. See https://github.com/apify/apify-sdk-python/issues/808.
if not queue_operation_info.was_already_handled:
handled_request_count += 1

assert handled_request_count == desired_request_count, (
f'handled_request_count={handled_request_count}',
Expand Down Expand Up @@ -92,10 +94,12 @@ async def test_add_requests_in_batches(
Actor.log.info(f'Processing request {handled_request_count + 1}...')
queue_operation_info = await rq.mark_request_as_handled(next_request)
assert queue_operation_info is not None, f'queue_operation_info={queue_operation_info}'
assert queue_operation_info.was_already_handled is False, (
f'queue_operation_info.was_already_handled={queue_operation_info.was_already_handled}'
)
handled_request_count += 1
# The request queue has at-least-once delivery: a request can occasionally be fetched again before the
# platform propagates its handled state, so the same request may be marked as handled more than once
# (`was_already_handled` reports the state before this update). Count only the first time each request is
# handled. See https://github.com/apify/apify-sdk-python/issues/808.
if not queue_operation_info.was_already_handled:
handled_request_count += 1

assert handled_request_count == desired_request_count, (
f'handled_request_count={handled_request_count}',
Expand Down Expand Up @@ -130,10 +134,12 @@ async def test_add_non_unique_requests_in_batch(
Actor.log.info(f'Processing request {handled_request_count + 1}: {next_request.url}')
queue_operation_info = await rq.mark_request_as_handled(next_request)
assert queue_operation_info is not None, f'queue_operation_info={queue_operation_info}'
assert queue_operation_info.was_already_handled is False, (
f'queue_operation_info.was_already_handled={queue_operation_info.was_already_handled}'
)
handled_request_count += 1
# The request queue has at-least-once delivery: a request can occasionally be fetched again before the
# platform propagates its handled state, so the same request may be marked as handled more than once
# (`was_already_handled` reports the state before this update). Count only the first time each request is
# handled. See https://github.com/apify/apify-sdk-python/issues/808.
if not queue_operation_info.was_already_handled:
handled_request_count += 1

expected_count = int(desired_request_count * 3 / 4)
assert handled_request_count == expected_count, (
Expand Down