[TODO]: update generated models from apify-docs PR #2689#894
Closed
apify-service-account wants to merge 1 commit into
Closed
[TODO]: update generated models from apify-docs PR #2689#894apify-service-account wants to merge 1 commit into
apify-service-account wants to merge 1 commit into
Conversation
apify-service-account
added
the
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 94.52% 94.54% +0.02%
==========================================
Files 48 48
Lines 5079 5116 +37
==========================================
+ Hits 4801 4837 +36
- Misses 278 279 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
added a commit
that referenced
this pull request
Jun 25, 2026
The `Regenerate models` workflow opened a new (and mostly empty) PR on every dispatch from a single apify-docs PR. For example, docs PR #2689 produced 7 client PRs (#888 to #894). Root cause: the "Point branch at current master" step force-pushed the shared `update-models-docs-pr-<N>` branch to master before committing. That intermediate "branch == master" state made the open PR's head identical to its base, which GitHub auto-closes. The next dispatch's `gh pr list --head` (open PRs only) then found nothing and created a brand-new PR, leaving the auto-closed one looking empty. Fix: drop the force-push-to-master step and append the regenerated models to the auto-update branch as signed ("Verified") commits via `apify/actions/signed-commit`. A fresh docs PR creates the branch and its first commit; each later commit on the docs PR appends another commit, so the client PR mirrors the docs PR and stays open throughout. Repeated dispatches that regenerate identical models add no commit (`committed=false`), and the docs-PR comment fires only when a PR is created or a commit is appended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the auto-generated Pydantic models and TypedDicts based on OpenAPI specification changes in apify-docs PR #2689.