Repository navigation
Run the wicket-core-tests classes Surefire skipped - #1727
Open
sharanggupta wants to merge 2 commits into
Open
sharanggupta wants to merge 2 commits into
sharanggupta wants to merge 2 commits into
Conversation
Surefire includes only **/*Test.java, so the thirteen test classes named Test* (TestHomePage in nine packages, TestHomePage_2134 in two, TestFormHasError and TestVariations) compile but never run. The include has been in the root pom since at least 2012, and most of these classes are older than that. Their 23 tests pass, so renaming them to *Test is all it takes to run them with the rest of the module.
StringResourceLoaderTestBase declares loaderUnknownResources as an abstract @test method. JUnit 4 ran a subclass override through that annotation, but JUnit Jupiter skips abstract methods and does not carry @test over to an override, so since the move to JUnit 5 the override in InitializerStringResourceLoaderTest has not run. The other three subclasses already annotate their override; annotate this one as well.
reiern70
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surefire only includes **/Test.java, so 13 classes in wicket-core-tests named Test (TestHomePage, TestHomePage_2134, TestFormHasError, TestVariations) never ran; this renames them to *Test. It also adds the missing @test to InitializerStringResourceLoaderTest#loaderUnknownResources, which Jupiter has skipped since the JUnit 5 migration because only the abstract base method carries @test. That is 24 more tests in wicket-core-tests, all passing.