ci(release): skip duplicate asset upload in publish workflow#80
Merged
Conversation
The Prepare Release workflow already attaches the plugin zip to the GitHub pre-release. Re-uploading from the publish workflow fails with "asset under the same name already exists" once the pre-release is promoted. Removing the redundant step also keeps the published bits identical to what PMC voted on.
|
🔌 Plugin artifact ready for testing! Download from Actions artifacts Artifact: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two-phase release setup attached the plugin zip to the GitHub
pre-release in
prepare_release.yml, thenrelease.ymltried toupload the same file again on promotion — failing the
v261.19017.1publish run with
asset under the same name already exists: [struts2-261.19017.1.zip].This removes the redundant
Upload Release Assetstep. The Marketplacepublish (the only step that needs to happen on promotion) already runs
before it, and the asset PMC voted on stays untouched.
See failing run: https://github.com/apache/struts-intellij-plugin/actions/runs/25051059276/job/73378668748
Test plan