Repository navigation
build: upgrade Gradle wrapper to 9.8.2 and enable build cache - #278
Merged
epugh merged 3 commits intoOct 26, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Enable org.gradle.caching and set -Dfile.encoding=UTF-8 in org.gradle.jvmargs per Gradle best practices. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Findings from the gradle-best-practices audit of this build: - use_configuration_cache: set org.gradle.configuration-cache=true. The `docker info` probe now goes through providers.exec instead of ProcessBuilder, and the JaCoCo class-directory filter no longer calls the eager FileCollection.files. - do_not_use_internal_apis: pick the Jib docker executable from the os.name system property instead of org.gradle.internal.os.OperatingSystem. - set_up_repositories_in_settings: declare repositories in dependencyResolutionManagement (root settings, and a new buildSrc settings file) rather than in each build script. - dont_hardcode_task_names: reference unitTest and bootBuildImage through their providers / typed accessors instead of string names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the
gradle-wrapper-upgradeandgradle-best-practicesagent skills to the build.Wrapper (
gradle-wrapper-upgrade)-bin,distributionSha256Sumpinned;:wrapperrun twice so the scripts and jar come from the new templates). Re-running the skill on 9.8.2 regenerates identical files.Best-practices audit (
gradle-best-practices)gradle.properties(ASF license header for RAT) enabling the build cache, the configuration cache, and UTF-8 for the Gradle daemon.use_build_cache,use_utf8_encoding,use_configuration_cachedocker infoprobe indockerIntegrationTestusesproviders.execinstead ofProcessBuilder, and the JaCoCo class-directory filter no longer calls the eagerFileCollection.files.avoid_eager_file_collection_apisos.nameinstead of the internalorg.gradle.internal.os.OperatingSystem.do_not_use_internal_apissettings.gradle.kts(and a newbuildSrc/settings.gradle.kts) instead of in each build script.set_up_repositories_in_settingsunitTestandbootBuildImageare referenced through their providers / typed accessors instead of string names.dont_hardcode_task_namesVerification
./gradlew buildpasses on 9.8.2 with JDK 25 (424 tests,spotlessCheckand RAT included), and./gradlew -p buildSrc testpasses.assembleandbuild -x test.Not included
Structural findings from the same audit, each its own change:
buildSrc/tobuild-logic/composite build, moving the Spring app out of the root project, and TestKit tests for the license/NOTICE task types.🤖 Generated with Claude Code