[adityamparikh]

Stacked on #269 (./gradlew build runs buildSrc's tests): the first commit here is #269, and only the top commit (style: format Java sources with google-java-format) is new.

What

Spotless now formats Java with google-java-format instead of the Eclipse JDT formatter, and the whole codebase is reformatted with it before 1.0.

• build.gradle.kts: the java block is googleJavaFormat("1.35.0") plus formatAnnotations(). google-java-format sorts imports and removes unused ones itself, so importOrder(), removeUnusedImports(), trimTrailingWhitespace() and endWithNewline() are gone.
• config/spotless/eclipse-java-formatter.properties is deleted. google-java-format has one fixed style, so there is nothing to configure.
• .editorconfig gets a [*.java] section that matches the formatter (2-space indent, 4-space continuation, 100 columns), so IDEs indent new code the same way.
• Everything else is ./gradlew spotlessApply over the Java sources.

Why

One style, applied the same way everywhere, with no formatter settings to tune or review. The Google style also gives the layout the codebase has been missing:

return listCollections().stream()
    .filter(c -> c != null && c.toLowerCase(Locale.ROOT).startsWith(prefix))
    .sorted()
    .limit(MAX_COMPLETION_RESULTS)
    .toList();

public record AliasResult(
    String aliasName,
    @Nullable String collections,
    boolean success,
    String message,
    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'")
        Date timestamp) {}

@McpTool(
    name = "list-collections",
    annotations = @McpTool.McpAnnotations(readOnlyHint = true),
    description = "List solr collections")

• Chains: once a chain doesn't fit, every call goes on its own line.
• Arguments: parameters, record components and annotation arguments that don't fit go one per line.
• Short code: whatever fits on one line, such as @McpComplete(prompt = PromptNames.VIEW_SCHEMA) or record SortClause(String field, String order), stays on one line.

The Eclipse formatter was adopted because google-java-format used to fail on new JDKs with NoSuchMethodError against javac internals. 1.35.0, Spotless 8.9.0's default, runs on JDK 25. It's pinned so a Spotless upgrade can't reformat the codebase by itself. The newest release, 1.37.0, fails on every file under JDK 25, with Spotless 8.9.0 and with 8.10.4.

Verification

• The change is formatting only. All 130 compiled classes in main and test match the previous output apart from line numbers. This includes instructions, string constants and annotation values (the @McpTool descriptions).
• Running ./gradlew spotlessApply again changes nothing.
• ./gradlew build passes, with all 465 tests run and none skipped, plus buildSrc's 12 tests, which run in the same build via build: run buildSrc's tests as part of the build #269.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[epugh]

better to format now then post 1.0!