fix(logs): adjust LogAssert log sorting to preserve expected order#59
Merged
Conversation
wu-sheng
reviewed
Sep 14, 2025
| @@ -1,3 +1,22 @@ | |||
| /* | |||
Member
There was a problem hiding this comment.
For latest mvnw, we don't need this Java class. For his older version, I am not sure whether it is proper to add ASF header.
Contributor
Author
There was a problem hiding this comment.
Do I need to delete this class or remove the ASF header?
mrproliu
reviewed
Sep 14, 2025
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.2 http://maven.apache.org/xsd/assembly-1.1.2.xsd"> | ||
| <id></id> | ||
| <id>mock-collector-assembly</id> |
Contributor
There was a problem hiding this comment.
Why you need to change this?
Contributor
There was a problem hiding this comment.
Please don’t change the default permission.
mrproliu
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**aim:**Added sorting in LogAssert to ensure consistent order when logs appear concurrently.
**changes:**added deterministic sorting to logsEquals in LogAssert to ensure that logs are compared consistently, regardless of the order in which they appear.
Logs are now sorted by endpoint → body.type → body.content before performing assertions.
add two new logs in test file