-
Notifications
You must be signed in to change notification settings - Fork 754
[GH-2511][Python] Add to_sedonadb() for SedonaSpark to SedonaDB conversion #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
5beaa27
27e1614
221a9cd
b8cf8c1
9cebd3e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import unittest | ||
| import sys | ||
| import sedona | ||
| import sedona.spark | ||
| from unittest.mock import MagicMock, patch | ||
| from pyspark.sql import SparkSession | ||
|
|
||
|
|
||
| class TestToSedonaDB(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| # Preserve original state | ||
| self._original_sedona_db_module = sys.modules.get("sedona.db") | ||
| self._had_sedona_db_attr = hasattr(sedona, "db") | ||
| self._original_sedona_db_attr = getattr(sedona, "db", None) | ||
|
|
||
| # Use getOrCreate without stopping it in tearDown to avoid CI crashes/hangs | ||
| # when other tests might be sharing the same JVM/session. | ||
| self.spark = SparkSession.builder.getOrCreate() | ||
|
|
||
| def tearDown(self): | ||
| # Restore prior sys.modules['sedona.db'] state | ||
| if "sedona.db" in sys.modules: | ||
| del sys.modules["sedona.db"] | ||
| if self._original_sedona_db_module is not None: | ||
| sys.modules["sedona.db"] = self._original_sedona_db_module | ||
|
|
||
| import sedona | ||
|
|
||
| # Restore prior sedona.db attribute state | ||
| if self._had_sedona_db_attr: | ||
| sedona.db = self._original_sedona_db_attr | ||
| elif hasattr(sedona, "db"): | ||
| del sedona.db | ||
|
Comment on lines
+36
to
+51
|
||
|
|
||
| @patch("sedona.spark.dataframe_to_arrow") | ||
| def test_to_sedonadb_no_connection(self, mock_dataframe_to_arrow): | ||
| # Mock sedona.db | ||
| mock_sedona_db = MagicMock() | ||
| sys.modules["sedona.db"] = mock_sedona_db | ||
| sedona.db = mock_sedona_db | ||
|
|
||
| mock_arrow_table = MagicMock() | ||
| mock_dataframe_to_arrow.return_value = mock_arrow_table | ||
|
|
||
| mock_connection = MagicMock() | ||
| mock_sedona_db.connect.return_value = mock_connection | ||
|
|
||
| mock_sedonadb_df = MagicMock() | ||
| mock_connection.create_data_frame.return_value = mock_sedonadb_df | ||
|
|
||
| # Create a dummy Spark DataFrame | ||
| df = self.spark.range(1) | ||
|
|
||
| # Call the method | ||
| result = df.to_sedonadb() | ||
|
|
||
| # Verify calls | ||
| mock_sedona_db.connect.assert_called_once() | ||
| mock_dataframe_to_arrow.assert_called_once_with(df) | ||
| mock_connection.create_data_frame.assert_called_once_with(mock_arrow_table) | ||
| self.assertEqual(result, mock_sedonadb_df) | ||
|
|
||
| @patch("sedona.spark.dataframe_to_arrow") | ||
| def test_to_sedonadb_with_connection(self, mock_dataframe_to_arrow): | ||
| # Force sedona.db to be missing to ensure it's not required when connection is provided | ||
| sys.modules["sedona.db"] = None | ||
| if hasattr(sedona, "db"): | ||
| del sedona.db | ||
|
|
||
| mock_arrow_table = MagicMock() | ||
| mock_dataframe_to_arrow.return_value = mock_arrow_table | ||
|
|
||
| mock_connection = MagicMock() | ||
| mock_sedonadb_df = MagicMock() | ||
| mock_connection.create_data_frame.return_value = mock_sedonadb_df | ||
|
|
||
| # Create a dummy Spark DataFrame | ||
| df = self.spark.range(1) | ||
|
|
||
| # Call the method | ||
| result = df.to_sedonadb(connection=mock_connection) | ||
|
|
||
| # Verify calls | ||
| mock_dataframe_to_arrow.assert_called_once_with(df) | ||
| mock_connection.create_data_frame.assert_called_once_with(mock_arrow_table) | ||
| self.assertEqual(result, mock_sedonadb_df) | ||
|
|
||
| def test_to_sedonadb_import_error(self): | ||
| # Force ImportError by setting the module to None in sys.modules | ||
| sys.modules["sedona.db"] = None | ||
| if hasattr(sedona, "db"): | ||
| del sedona.db | ||
|
|
||
| # Create a dummy Spark DataFrame | ||
| df = self.spark.range(1) | ||
|
|
||
| # Call the method and expect ImportError | ||
| with self.assertRaises(ImportError) as cm: | ||
| df.to_sedonadb() | ||
|
|
||
| self.assertEqual( | ||
| str(cm.exception), | ||
| "SedonaDB is not installed. Please install it using `pip install sedona-db`.", | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function imports
sedona.dbunconditionally, even when aconnectionis explicitly provided. That makes the method fail withImportErrorin cases where a caller passes a compatible connection object (or in environments doing partial installs) even thoughsedona.dbisn’t required on that code path. Move theimport sedona.db+connect()logic inside theif connection is None:branch so only the auto-connect path requires the SedonaDB package.