NIFI-15815 connector details page#11254
Merged
Merged
Conversation
Contributor
|
Reviewing... |
mcgilman
reviewed
May 19, 2026
Contributor
mcgilman
left a comment
There was a problem hiding this comment.
Nice, clean addition — the split into ConnectorDetail + ConnectorDetailsContent is the right shape, sandbox flags are correctly tightened for a read-only view, and the spec coverage on the visibility branches is thorough.
A few comments below; the only one with real substance is the getFrameSource sanitize-then-bypass pattern, which is duplicated from ConnectorConfigure and worth fixing in both. The rest are small consistency/optional nits.
mcgilman
approved these changes
May 21, 2026
Contributor
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15815
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation