NIFI-15916 Log dropped FlowFiles when content is missing#11221
Open
awelless wants to merge 1 commit intoapache:mainfrom
Open
NIFI-15916 Log dropped FlowFiles when content is missing#11221awelless wants to merge 1 commit intoapache:mainfrom
awelless wants to merge 1 commit intoapache:mainfrom
Conversation
In handleContentNotFound both branches threw MissingFlowFileException with the same generic "Unable to find content for FlowFile" message, giving operators no FlowFile identity and no way to distinguish an unrecoverable drop from a recoverable rollback. Registered-claim branch (markForAbort + drop): enrich the exception message with the FlowFile identity and emit a WARN log so the drop is recorded even if the caller swallows the exception. Transient-claim branch (rollback returns the FlowFile to its queue): enrich the message only - name the in-flight content and signal the session is rolling back so callers can tell this is recoverable.
awelless
commented
May 8, 2026
| final MissingFlowFileException ex = assertThrows(MissingFlowFileException.class, | ||
| () -> session.read(ff1, InputStream::read)); | ||
| assertTrue(ex.getMessage().contains("12345678-1234-1234-1234-123456789012")); | ||
| assertTrue(ex.getMessage().contains("rolling back")); |
Contributor
Author
There was a problem hiding this comment.
In general asserting exception messages is a questionable practice. But since this change is focusing on the messages in particular, I wanted to ensure the change is covered.
Let me know if you see it redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15916
In
handleContentNotFoundboth branches threwMissingFlowFileExceptionwith the same generic "Unable to find content for FlowFile" message, giving operators no FlowFile identity and no way to distinguish an unrecoverable drop from a recoverable rollback.Registered-claim branch (
markForAbort+ drop): enrich the exception message with the FlowFile identity and emit a WARN log so the drop is recorded even if the caller swallows the exception.Transient-claim branch (rollback returns the FlowFile to its queue): enrich the message only - name the in-flight content and signal the session is rolling back so callers can tell this is recoverable.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation