[QDP] Enhance benchmark's installation journey#1154
Open
0lai0 wants to merge 3 commits intoapache:mainfrom
Open
[QDP] Enhance benchmark's installation journey#11540lai0 wants to merge 3 commits intoapache:mainfrom
0lai0 wants to merge 3 commits intoapache:mainfrom
Conversation
guan404ming
reviewed
Mar 8, 2026
| Then run individual benchmarks: | ||
|
|
||
| ```bash | ||
| uv sync --group dev --extra qdp |
Member
There was a problem hiding this comment.
Why do we need to remove these lines?
Contributor
Author
There was a problem hiding this comment.
Good catch! Thanks @guan404ming.
I found that setup-benchmark should include uv sync --group dev --extra qdp to ensure the qumat-qdp package path is properly registered in the environment, consistent with the development environment setup in DEVELOPMENT.md.
I will fix the Makefile to include this, and also restore the manual setup steps in the README as an alternative option. Will push a fix shortly!
Contributor
Author
There was a problem hiding this comment.
I moved this line because it will be handled in make benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1141
Changes
Why
Currently,
make benchmarkdoesn't exist, and setting up benchmarks requires multiple manual steps. Since the Python environment has been unified to use the root.venv, we should provide a simplemake benchmarkcommand from the root directory to streamline the benchmark setup and execution process.How
benchmarkandsetup-benchmarktargets to the rootMakefilesetup-benchmark: Installs benchmark dependencies and builds QDP extensionbenchmark: Sets up environment and displays instructions for running benchmarksqdp/qdp-python/benchmark/README.mdto documentmake benchmarkas the recommended wayqdp/DEVELOPMENT.mdto includemake benchmarkin the benchmarks sectionChecklist