fix(release-promote): grade svn mv -m, not a separate svn commit - #969
Merged
justinmclean merged 2 commits intoJul 27, 2026
Merged
Conversation
The step-2 eval rule required a follow-up svn commit even though a URL-to-URL svn mv commits immediately with its own -m. Align the grader and skill prose with the paste-ready command block the skill emits. Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
Make the output-spec clause grammatical: \"references\" instead of \"referencing\" so the rule reads as a clear requirement. Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
justinmclean
approved these changes
Jul 27, 2026
justinmclean
left a comment
Member
There was a problem hiding this comment.
Diagnosis confirmed against the skill itself. Its svnpubsub block emits svn mv ... -m "Promoting Apache (from rc). [RESULT]: <result_vote_url>" and there is no svn commit anywhere in it; SKILL.md line 51 and line 356 both describe the move as the promote commit. So the old rule demanded a command the skill never emits. The two SKILL.md table rows changed here were the only two svn commit mentions left in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-promotestep-2 eval grading rule sosvnpubsubrequiressvn mvwith inline-mreferencing the[RESULT] [VOTE]URL, not aseparate
svn commit -mthat the skill never emits and SVN does not needfor URL-to-URL moves.
release-promoteSKILL.md lines from "svn commit message" to"svn mv -m message" so the prose matches the paste-ready command block.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowuv.lockmetadata refresh from the vendor-neutrality hook whenthe skill file was staged (mypy specifier sync)
Test plan
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/release-promote/loads all 8 cases; step-2 system prompt shows the corrected svnpubsub grading rulesvn mv+-mwith RESULT URL; no separatesvn commit)prekcommit hooks pass on changed filesSigned-off-by)RFC-AI-0004 compliance
Linked issues
Closes #939