Skip to content

fix(release-promote): grade svn mv -m, not a separate svn commit - #969

Merged
justinmclean merged 2 commits into
apache:mainfrom
Shaurya2k06:fix/release-promote-svn-mv-grading
Jul 27, 2026
Merged

fix(release-promote): grade svn mv -m, not a separate svn commit#969
justinmclean merged 2 commits into
apache:mainfrom
Shaurya2k06:fix/release-promote-svn-mv-grading

Conversation

@Shaurya2k06

Copy link
Copy Markdown
Contributor

Summary

  • Fix the release-promote step-2 eval grading rule so svnpubsub requires
    svn mv with inline -m referencing the [RESULT] [VOTE] URL, not a
    separate svn commit -m that the skill never emits and SVN does not need
    for URL-to-URL moves.
  • Retarget two release-promote SKILL.md lines from "svn commit message" to
    "svn mv -m message" so the prose matches the paste-ready command block.

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Other: uv.lock metadata refresh from the vendor-neutrality hook when
    the skill file was staged (mypy specifier sync)

Test plan

  • PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/release-promote/ loads all 8 cases; step-2 system prompt shows the corrected svnpubsub grading rule
  • Case-1 (svnpubsub) assertion checks pass against skill-shaped output (svn mv + -m with RESULT URL; no separate svn commit)
  • prek commit hooks pass on changed files
  • Commit is GPG-signed and DCO-signed (Signed-off-by)

RFC-AI-0004 compliance

  • HITL — any new mutation is gated on explicit user confirmation
  • Sandbox — no new unrestricted host access; network reach declared in the adapter
  • Vendor neutrality — placeholders used in all skill / tool prose
  • Conversational + correctable — agentic-override path documented if behaviour is adopter-tunable
  • Write-access discipline — no autonomous outbound messages; drafts only, sent on confirmation
  • Privacy LLM — private content does not reach a non-approved LLM; redactor invoked where needed

Linked issues

Closes #939

The step-2 eval rule required a follow-up svn commit even though a
URL-to-URL svn mv commits immediately with its own -m. Align the grader
and skill prose with the paste-ready command block the skill emits.

Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
Make the output-spec clause grammatical: \"references\" instead of
\"referencing\" so the rule reads as a clear requirement.

Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>

@justinmclean justinmclean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagnosis confirmed against the skill itself. Its svnpubsub block emits svn mv ... -m "Promoting Apache (from rc). [RESULT]: <result_vote_url>" and there is no svn commit anywhere in it; SKILL.md line 51 and line 356 both describe the move as the promote commit. So the old rule demanded a command the skill never emits. The two SKILL.md table rows changed here were the only two svn commit mentions left in the file.

@justinmclean
justinmclean merged commit 7c1a05e into apache:main Jul 27, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop the release-promote eval requiring an svn commit the skill never emits

2 participants