Add FieldMinMax unified API for global numeric min/max retrieval#15752
Open
SYEDMDSAAD wants to merge 2 commits intoapache:mainfrom
Open
Add FieldMinMax unified API for global numeric min/max retrieval#15752SYEDMDSAAD wants to merge 2 commits intoapache:mainfrom
SYEDMDSAAD wants to merge 2 commits intoapache:mainfrom
Conversation
f879b41 to
625df71
Compare
625df71 to
ac19825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces FieldMinMax, a unified API to retrieve global
minimum and maximum numeric values for a field across an IndexReader.
Currently Lucene exposes two different mechanisms:
PointValues.getMinPackedValue / getMaxPackedValue
DocValuesSkipper.globalMinValue / globalMaxValue
This forces callers to understand internal storage details and manually filter invalid values.
FieldMinMax abstracts over both implementations and provides consistent behavior:
This prevents sentinel leakage and simplifies caller logic.
Tests cover: