Skip to content

Comments

Adding ide files to gitignore#15738

Open
jainankitk wants to merge 1 commit intoapache:mainfrom
jainankitk:ignore
Open

Adding ide files to gitignore#15738
jainankitk wants to merge 1 commit intoapache:mainfrom
jainankitk:ignore

Conversation

@jainankitk
Copy link
Contributor

Description

Adds ide files to gitignore. Also, gets rid of .vscode configuration files (probably added by mistake?)

Signed-off-by: Ankit Jain <jainankitk@apache.org>
@jainankitk jainankitk added the skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. label Feb 20, 2026
@dweiss
Copy link
Contributor

dweiss commented Feb 20, 2026

Looking at the logs, .vscode files were added intentionally to improve life for people using this ide. I'd leave them.

@jainankitk
Copy link
Contributor Author

Looking at the logs, .vscode files were added intentionally to improve life for people using this ide. I'd leave them.

Yeah, I wanted to do that initially. But, I have to make some changes to settings which might not make sense for others:

% git diff
diff --git a/.vscode/settings.json b/.vscode/settings.json
index 1aab898912..082f7caccb 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,6 +1,6 @@
 {
   "java.server.launchMode": "Standard",
-  "java.import.gradle.enabled": false,
+  "java.import.gradle.enabled": true,
   "java.import.maven.enabled": false,
   "java.jdt.ls.lombokSupport.enabled": false,
   "java.compile.nullAnalysis.mode": "disabled",
@@ -9,5 +9,16 @@
   "java.inlayHints.parameterNames.enabled": "all",
   "java.inlayHints.parameterTypes.enabled": true,
   "java.inlayHints.variableTypes.enabled": true,
   "redhat.telemetry.enabled": false
+  "java.configuration.runtimes": [
+    {
+      "name": "JavaSE-25",
+      "path": "/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
+      "default": true
+    }
+  ],
+  "java.jdt.ls.java.home": "/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
+  "java.import.gradle.java.home": "/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home",
+  "gradle.java.home": "/Library/Java/JavaVirtualMachines/amazon-corretto-25.jdk/Contents/Home"
 }

Hence, better to ignore these altogether so every developer can maintain their local copy? I am assuming these files are created automatically while setting up the workspace initially?

@rmuir
Copy link
Member

rmuir commented Feb 20, 2026

Please don't remove the vscode setup. Also don't save your settings there. Save your settings at "User" level (which will not touch these files and will instead always override them) instead of "Workspace"

Copy link
Member

@rmuir rmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this and remove these files, I worked to create this setup and I don't even use vscode. please modify settings at "User" level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants