Skip to content

Comments

Update DirectoryTaxonomyReader.java to let getBulkPath use cache#15711

Open
shubhamsrkdev wants to merge 3 commits intoapache:mainfrom
shubhamsrkdev:bulkPathCache
Open

Update DirectoryTaxonomyReader.java to let getBulkPath use cache#15711
shubhamsrkdev wants to merge 3 commits intoapache:mainfrom
shubhamsrkdev:bulkPathCache

Conversation

@shubhamsrkdev
Copy link
Contributor

@shubhamsrkdev shubhamsrkdev commented Feb 17, 2026

Problem

getBulkPath is calling getPathFromCache but never uses the value.

Solution

Use the output of getPathFromCache and only sort uncached ordinals

Fixes #15705

Testing

python src/python/localrun.py -source wikimediumall

                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
       BrowseDayOfYearSSDVFacets        4.64     (11.1%)        4.42      (9.2%)   -4.7% ( -22% -   17%) 0.143
            BrowseDateSSDVFacets        0.92      (7.8%)        0.90      (9.1%)   -1.9% ( -17% -   16%) 0.485
          OrHighMedDayTaxoFacets        2.37      (2.2%)        2.34      (3.2%)   -1.4% (  -6% -    4%) 0.108
           BrowseMonthSSDVFacets        4.48      (7.9%)        4.42      (9.1%)   -1.4% ( -17% -   16%) 0.614
             LowIntervalsOrdered      180.34      (8.4%)      177.96      (7.7%)   -1.3% ( -16% -   16%) 0.605
                   OrHighNotHigh      323.74      (4.6%)      319.51      (6.1%)   -1.3% ( -11% -    9%) 0.442
                   OrNotHighHigh      400.76      (5.0%)      395.66      (6.3%)   -1.3% ( -12% -   10%) 0.481
             MedIntervalsOrdered      120.07      (8.2%)      118.60      (7.4%)   -1.2% ( -15% -   15%) 0.622
                    OrHighNotMed      897.90      (3.6%)      888.12      (5.0%)   -1.1% (  -9% -    7%) 0.425
                    OrHighNotLow      953.11      (4.1%)      943.75      (5.1%)   -1.0% (  -9% -    8%) 0.504
            HighIntervalsOrdered       11.65      (4.9%)       11.55      (4.6%)   -0.9% (  -9% -    9%) 0.548
                        HighTerm      883.51      (4.8%)      875.97      (4.7%)   -0.9% (  -9% -    9%) 0.571
                      TermDTSort      311.71      (2.5%)      309.22      (3.0%)   -0.8% (  -6% -    4%) 0.361
                    OrNotHighLow     1621.09      (4.0%)     1608.32      (2.9%)   -0.8% (  -7% -    6%) 0.480
           HighTermDayOfYearSort      366.45      (3.2%)      364.28      (2.5%)   -0.6% (  -6% -    5%) 0.512
                      AndHighLow     1577.31      (3.5%)     1568.12      (4.7%)   -0.6% (  -8% -    7%) 0.657
                          IntNRQ      353.52      (1.7%)      352.15      (1.7%)   -0.4% (  -3% -    3%) 0.474
                       OrHighLow     1244.38      (1.6%)     1240.12      (3.0%)   -0.3% (  -4% -    4%) 0.657
            MedTermDayTaxoFacets       39.71      (0.7%)       39.58      (1.2%)   -0.3% (  -2% -    1%) 0.298
                     AndHighHigh      328.04      (3.3%)      327.14      (3.3%)   -0.3% (  -6% -    6%) 0.793
               HighTermMonthSort     1500.91      (3.2%)     1499.56      (2.1%)   -0.1% (  -5% -    5%) 0.917
           BrowseMonthTaxoFacets        2.80      (1.5%)        2.80      (1.5%)   -0.1% (  -3% -    3%) 0.891
                    OrNotHighMed      383.93      (5.5%)      383.73      (5.9%)   -0.1% ( -10% -   12%) 0.976
                        PKLookup      204.14      (3.4%)      204.13      (2.3%)   -0.0% (  -5% -    5%) 0.995
                          Fuzzy2       62.40      (1.8%)       62.42      (2.3%)    0.0% (  -4% -    4%) 0.967
                         Respell       35.38      (2.1%)       35.39      (2.0%)    0.0% (  -4% -    4%) 0.961
                          Fuzzy1       86.82      (2.3%)       86.89      (2.4%)    0.1% (  -4% -    4%) 0.914
            HighTermTitleBDVSort       63.59      (1.4%)       63.64      (1.5%)    0.1% (  -2% -    3%) 0.849
                      AndHighMed      845.72      (1.9%)      846.79      (1.4%)    0.1% (  -3% -    3%) 0.809
                      HighPhrase      109.78      (1.1%)      109.93      (0.8%)    0.1% (  -1% -    2%) 0.657
                       LowPhrase      120.97      (0.9%)      121.16      (0.9%)    0.2% (  -1% -    2%) 0.573
                         LowTerm     1944.87      (2.8%)     1948.11      (2.9%)    0.2% (  -5% -    5%) 0.852
        AndHighHighDayTaxoFacets       34.92      (1.0%)       34.99      (0.9%)    0.2% (  -1% -    2%) 0.503
                      OrHighHigh      157.82      (5.7%)      158.17      (5.4%)    0.2% ( -10% -   12%) 0.898
                         MedTerm     1015.45      (4.5%)     1018.06      (4.7%)    0.3% (  -8% -    9%) 0.859
         AndHighMedDayTaxoFacets       48.94      (0.8%)       49.06      (0.6%)    0.3% (  -1% -    1%) 0.256
                         Prefix3      929.61      (3.3%)      932.87      (4.0%)    0.4% (  -6% -    7%) 0.764
     BrowseRandomLabelTaxoFacets        2.44      (1.8%)        2.45      (1.8%)    0.4% (  -3% -    4%) 0.440
                       OrHighMed      780.54      (2.3%)      784.00      (1.7%)    0.4% (  -3% -    4%) 0.489
                       MedPhrase      228.74      (1.0%)      229.77      (0.8%)    0.4% (  -1% -    2%) 0.118
                        Wildcard      293.55      (4.5%)      294.99      (5.2%)    0.5% (  -8% -   10%) 0.751
                     LowSpanNear       60.65      (1.0%)       60.99      (0.8%)    0.6% (  -1% -    2%) 0.060
                 MedSloppyPhrase      143.67      (1.8%)      144.52      (1.2%)    0.6% (  -2% -    3%) 0.231
                 LowSloppyPhrase      392.79      (1.6%)      395.11      (1.5%)    0.6% (  -2% -    3%) 0.234
                HighSloppyPhrase       38.03      (2.0%)       38.32      (1.2%)    0.8% (  -2% -    4%) 0.150
                    HighSpanNear       42.60      (1.4%)       42.92      (1.9%)    0.8% (  -2% -    4%) 0.157
                  AndMissingHigh     2280.94      (5.6%)     2301.22      (5.5%)    0.9% (  -9% -   12%) 0.610
                     MedSpanNear       51.26      (1.8%)       51.72      (1.8%)    0.9% (  -2% -    4%) 0.124
                           range     2131.49      (7.7%)     2151.21      (8.1%)    0.9% ( -13% -   18%) 0.711
       BrowseDayOfYearTaxoFacets        3.20      (4.1%)        3.24      (4.6%)    1.4% (  -7% -   10%) 0.321
            BrowseDateTaxoFacets        3.18      (4.3%)        3.22      (4.8%)    1.4% (  -7% -   10%) 0.331
               HighTermTitleSort      112.35      (6.7%)      114.14      (5.1%)    1.6% (  -9% -   14%) 0.398
                          IntSet      767.40      (5.7%)      783.62      (6.0%)    2.1% (  -9% -   14%) 0.255
     BrowseRandomLabelSSDVFacets        3.25      (6.0%)        3.35     (13.0%)    3.0% ( -15% -   23%) 0.346

@github-actions github-actions bot added this to the 10.5.0 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DirectoryTaxonomyReader#getBulkPath doesn't use cache

2 participants