GITHUB#15654: Fix testDocValues to assert singleton behavior#15666
Open
ML-dev-crypto wants to merge 1 commit intoapache:mainfrom
Open
GITHUB#15654: Fix testDocValues to assert singleton behavior#15666ML-dev-crypto wants to merge 1 commit intoapache:mainfrom
ML-dev-crypto wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
This PR only updates a test and does not change runtime behavior. |
Contributor
|
Thanks for opening this PR @ML-dev-crypto. I think we need a different solution here: I've outlined my idea in #15596 (comment) |
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestExitableDirectoryReader.testDocValues asserted concrete
SortedSetDocValues / SortedNumericDocValues implementation types,
which is not guaranteed across codecs (e.g., SimpleText).
This change updates the test to assert singleton behavior via
docValueCount() == 1, making it codec-agnostic while still
validating that ExitableDirectoryReader preserves singleton
doc values semantics.
The failure is reproducible with the CI seed reported in #15654.