Potential fix for code scanning alert no. 39: Workflow does not contain permissions#676
Merged
Potential fix for code scanning alert no. 39: Workflow does not contain permissions#676
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jarek Potiuk <jarek@potiuk.com>
Member
Author
|
Ths is a no-risk change and it's just best practice to limit permissions in the workflows. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/apache/infrastructure-actions/security/code-scanning/39
In general, the fix is to explicitly declare a
permissions:block that restricts theGITHUB_TOKENto the least privileges needed. For a pure linting/type-check workflow that only reads the repository contents and does not interact with issues, PRs, or other GitHub resources, the minimal useful scope iscontents: read. This can be set at the workflow root (applies to all jobs) or at the job level; here a single job exists, so root-level is simplest and future-proof if more jobs are added.Concretely, in
.github/workflows/linting.yml, add a top-levelpermissions:block after theon:section (or beforejobs:) settingcontents: read. This does not change functional behavior of the linting steps but ensures theGITHUB_TOKENcannot be used for write operations on repository contents. No additional imports or methods are needed since this is just YAML configuration.Suggested fixes powered by Copilot Autofix. Review carefully before merging.