fix(golang): update metrics doc to latest version#3192
Open
Alanxtl wants to merge 1 commit intoapache:masterfrom
Open
fix(golang): update metrics doc to latest version#3192Alanxtl wants to merge 1 commit intoapache:masterfrom
Alanxtl wants to merge 1 commit intoapache:masterfrom
Conversation
✅ Deploy Preview for dubbo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AlexStocks
reviewed
Mar 23, 2026
Contributor
AlexStocks
left a comment
There was a problem hiding this comment.
文档更新内容较多,整体结构更清晰了。发现几个问题:
1. 标题格式混乱:
- 英文章节用「# 1.」「## 1️⃣」混用 emoji
- 中文章节用「# 一、」「## 1️⃣」混用数字和 emoji
2. app_port 描述模糊:
Pull 模式部分写的是 http://localhost:<app_port>/prometheus,但没说明这个端口是什么(Provider 还是 Consumer 端口?默认是多少?)
3. grafana.json 来源不明:
Step 4.2 说"Upload grafana.json",但这个文件在哪里?示例仓库里有吗?需要给出具体路径或下载链接。
4. RBAC 配置缺失:
旧版本有完整的 Role/RoleBinding 配置,新版本删掉了。如果集群启用了 RBAC,Prometheus 无法访问 Pod 指标,建议保留 RBAC 配置作为可选步骤。
5. tools/pgw-cleaner 位置不明:
文中提到这个工具用于清理僵尸指标,但在哪个仓库?dubbo-go 还是独立项目?需要说明清楚。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.