branch-4.0: [Enhancement](auth) Improve password validation to align with MySQL STRONG policy #60188 #60299
+515
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRONG policy (#60188) ### What problem does this PR solve? Enhance the validatePlainPassword function in MysqlPassword.java to fully comply with MySQL's STRONG password validation policy. Changes: 1. Require all 4 character types (digit, lowercase, uppercase, special character) instead of the previous "3 out of 4" requirement. 2. Add dictionary word check to reject passwords containing common weak words. - Built-in dictionary includes common words like: password, admin, test, root, etc. - Support loading custom dictionary from external file via the new global variable `validate_password_dictionary_file`. 3. Implement lazy loading for external dictionary file: - Dictionary is loaded on first password validation call. - Automatically reloads when the file path is changed. - Falls back to built-in dictionary if file loading fails. 4. Improve error messages to clearly indicate which requirements are missing. 5. Add comprehensive unit tests for all validation scenarios. Change the password dictionary file path resolution to use `Config.security_plugins_dir` as the base directory prefix. New `GlobalVariable.validatePasswordDictionaryFile` only needs to specify the filename, and the full path will be constructed as: `${security_plugins_dir}/<filename>`
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #60188