Skip to content

[bug](cloud restore) Fix load failed after table restore #60212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xy720 merged 1 commit into from
Jan 26, 2026
Merged

[bug](cloud restore) Fix load failed after table restore #60212

xy720 merged 1 commit into from
Jan 26, 2026

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Jan 24, 2026 •
edited
Loading

What problem does this PR solve?

How to reproduce:

1、create a table with 3 replica and backup it to repo

CREATE TABLE `test_tbl_3_replica` (
  `companyId` bigint NULL,
  `jobId` bigint NULL,
  `province` text NULL,
  `vCallerId` bigint NULL DEFAULT "0",
  `aCallerId` bigint NULL DEFAULT "-1"
) ENGINE=OLAP
DUPLICATE KEY(`companyId`)
DISTRIBUTED BY HASH(`companyId`) BUCKETS 8
PROPERTIES (
"replication_allocation" = "tag.location.default: 3"
);

2、set reserve_replica = true in restore command.

RESTORE SNAPSHOT test.`snapshot_label` FROM `test_repo` PROPERTIES ( "backup_timestamp" = "2026-01-23-16-20-57", "reserve_replica" = "true");

3、after restore finished, insert into the restored table.

mysql> insert into test_tbl_3_replica values(100,100,'广东',3,3);
Error1105:errCode=2, detailMessage = tablet 1768908267608 alive replicanum 1 < load required replicanum 2, alivebackends: [1768462881465]

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 24, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xy720
Copy link
Member Author

xy720 commented Jan 24, 2026

run buildall

@xy720 xy720 mentioned this pull request Jan 24, 2026
Open
16 tasks
@doris-robot
Copy link

doris-robot commented Jan 24, 2026

TPC-H: Total hot run time: 30997 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 61d941c2f81066477e90df9685c5bcee80780525, data reload: false

------ Round 1 ----------------------------------
q1	17655	4766	4586	4586
q2	2077	301	194	194
q3	10242	1286	704	704
q4	10222	855	299	299
q5	7559	2047	1826	1826
q6	179	167	138	138
q7	893	698	564	564
q8	9262	1344	1085	1085
q9	4853	4459	4588	4459
q10	6769	1626	1223	1223
q11	517	300	273	273
q12	333	374	220	220
q13	17785	3792	3115	3115
q14	236	247	208	208
q15	611	526	539	526
q16	643	640	582	582
q17	647	790	479	479
q18	6455	6429	6574	6429
q19	1393	1031	658	658
q20	414	358	249	249
q21	3013	2328	2158	2158
q22	1164	1085	1022	1022
Total cold run time: 102922 ms
Total hot run time: 30997 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5007	4962	4964	4962
q2	325	422	325	325
q3	2372	2898	2590	2590
q4	1391	1967	1466	1466
q5	4692	4557	4471	4471
q6	216	174	127	127
q7	2147	1968	1824	1824
q8	2509	2363	2453	2363
q9	7270	7099	7010	7010
q10	2449	2737	2089	2089
q11	512	461	429	429
q12	657	696	572	572
q13	3322	3774	3070	3070
q14	273	284	262	262
q15	546	504	491	491
q16	623	660	609	609
q17	1123	1295	1327	1295
q18	7213	7166	7088	7088
q19	836	803	788	788
q20	1901	1996	1820	1820
q21	4430	4220	4058	4058
q22	1060	1032	932	932
Total cold run time: 50874 ms
Total hot run time: 48641 ms

@doris-robot
Copy link

doris-robot commented Jan 24, 2026

TPC-DS: Total hot run time: 171357 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 61d941c2f81066477e90df9685c5bcee80780525, data reload: false

query5	4435	617	489	489
query6	320	208	186	186
query7	4220	453	263	263
query8	340	246	226	226
query9	8708	2884	2845	2845
query10	491	312	274	274
query11	15170	15146	14766	14766
query12	179	116	118	116
query13	1286	466	379	379
query14	6495	3009	2746	2746
query14_1	2660	2636	2646	2636
query15	205	193	170	170
query16	976	485	451	451
query17	1096	686	577	577
query18	2661	440	339	339
query19	199	178	151	151
query20	138	122	114	114
query21	221	146	120	120
query22	3813	4138	3758	3758
query23	16087	15427	15332	15332
query23_1	15385	15361	15229	15229
query24	7234	1513	1143	1143
query24_1	1161	1173	1174	1173
query25	535	468	426	426
query26	1253	271	157	157
query27	2722	446	278	278
query28	4541	2172	2176	2172
query29	826	525	418	418
query30	305	225	204	204
query31	771	616	547	547
query32	85	75	71	71
query33	522	330	295	295
query34	880	877	525	525
query35	731	767	658	658
query36	885	885	830	830
query37	146	99	86	86
query38	2737	2710	2641	2641
query39	765	756	736	736
query39_1	694	698	716	698
query40	221	132	115	115
query41	66	63	64	63
query42	90	89	94	89
query43	459	471	412	412
query44	1349	735	751	735
query45	194	184	173	173
query46	814	937	577	577
query47	1370	1408	1421	1408
query48	313	345	235	235
query49	604	430	343	343
query50	658	260	197	197
query51	3779	3797	3761	3761
query52	92	95	78	78
query53	212	223	177	177
query54	285	257	244	244
query55	83	77	75	75
query56	304	295	288	288
query57	977	980	888	888
query58	271	252	260	252
query59	2155	2071	2146	2071
query60	330	325	314	314
query61	149	171	148	148
query62	410	368	312	312
query63	194	151	166	151
query64	4828	1137	826	826
query65	3754	3711	3726	3711
query66	1394	415	316	316
query67	15402	15506	15400	15400
query68	2357	1046	737	737
query69	407	313	264	264
query70	1011	936	935	935
query71	296	288	265	265
query72	5243	3057	3236	3057
query73	606	717	304	304
query74	8649	8713	8533	8533
query75	2247	2339	1893	1893
query76	2293	1042	656	656
query77	350	416	308	308
query78	9590	9792	9003	9003
query79	1054	948	587	587
query80	622	508	444	444
query81	463	261	233	233
query82	1292	156	120	120
query83	358	258	234	234
query84	246	121	99	99
query85	815	459	403	403
query86	365	296	297	296
query87	2874	2903	2745	2745
query88	3513	2598	2555	2555
query89	300	256	237	237
query90	1867	174	163	163
query91	176	160	129	129
query92	72	71	65	65
query93	1035	982	643	643
query94	449	316	306	306
query95	566	330	369	330
query96	637	514	230	230
query97	2326	2366	2327	2327
query98	227	205	201	201
query99	583	565	490	490
Total cold run time: 244703 ms
Total hot run time: 171357 ms

@doris-robot
Copy link

doris-robot commented Jan 24, 2026

ClickBench: Total hot run time: 26.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 61d941c2f81066477e90df9685c5bcee80780525, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.04	0.04
query3	0.25	0.08	0.09
query4	1.62	0.12	0.11
query5	0.27	0.24	0.26
query6	1.15	0.67	0.64
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.58	0.50	0.50
query10	0.54	0.54	0.55
query11	0.14	0.09	0.10
query12	0.14	0.11	0.11
query13	0.60	0.58	0.58
query14	0.95	0.94	0.93
query15	0.80	0.77	0.78
query16	0.40	0.40	0.42
query17	1.06	1.03	1.07
query18	0.23	0.22	0.22
query19	1.89	1.82	1.83
query20	0.02	0.01	0.02
query21	15.41	0.26	0.13
query22	5.26	0.05	0.05
query23	15.86	0.28	0.10
query24	0.98	0.56	0.39
query25	0.12	0.07	0.05
query26	0.14	0.13	0.13
query27	0.09	0.08	0.08
query28	4.02	1.08	0.89
query29	12.53	4.00	3.18
query30	0.28	0.14	0.13
query31	2.80	0.65	0.39
query32	3.24	0.57	0.46
query33	3.06	3.04	3.05
query34	16.27	5.09	4.42
query35	4.48	4.41	4.44
query36	0.65	0.51	0.48
query37	0.10	0.06	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.16	0.14	0.13
query41	0.10	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 96.64 s
Total hot run time: 26.89 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 24, 2026

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 24, 2026

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 25, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2026

PR approved by anyone and no changes requested.

lide-reed
lide-reed approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 845a903 into apache:master Jan 26, 2026
39 of 40 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 26, 2026
@xy720
[bug](cloud restore) Fix load failed after table restore (#60212)
a53c8ff 
### What problem does this PR solve?

How to reproduce:

1、create a table with 3 replica and backup it to repo

```
CREATE TABLE `test_tbl_3_replica` (
  `companyId` bigint NULL,
  `jobId` bigint NULL,
  `province` text NULL,
  `vCallerId` bigint NULL DEFAULT "0",
  `aCallerId` bigint NULL DEFAULT "-1"
) ENGINE=OLAP
DUPLICATE KEY(`companyId`)
DISTRIBUTED BY HASH(`companyId`) BUCKETS 8
PROPERTIES (
"replication_allocation" = "tag.location.default: 3"
);
```

2、set `reserve_replica = true` in restore command.

```
RESTORE SNAPSHOT test.`snapshot_label` FROM `test_repo` PROPERTIES ( "backup_timestamp" = "2026-01-23-16-20-57", "reserve_replica" = "true");
```

3、after restore finished, insert into the restored table.

```
mysql> insert into test_tbl_3_replica values(100,100,'广东',3,3);
Error1105:errCode=2, detailMessage = tablet 1768908267608 alive replicanum 1 < load required replicanum 2, alivebackends: [1768462881465]
```
@github-actions github-actions bot mentioned this pull request Jan 26, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 26, 2026
@github-actions @xy720
branch-4.0: [bug](cloud restore) Fix load failed after table restore #…
bb27548 
…60212 (#60233)

Cherry-picked from #60212

Co-authored-by: xy720 <22125576+xy720@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xy720 @Thearas @doris-robot @hello-stephen @lide-reed @gavinchou @yiguolei