Skip to content

[Fix] (udf) fix frontends udf return rows incompatible with show frontends command #60211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
heguanhui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] (udf) fix frontends udf return rows incompatible with show frontends command #60211

heguanhui wants to merge 1 commit into from
+5 −3

Conversation

@heguanhui
Copy link
Contributor

@heguanhui heguanhui commented Jan 24, 2026 •
edited
Loading

What problem does this PR solve?

Fix frontends udf return rows incompatible with show frontends command

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
        测试报告.docx

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 24, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui
Copy link
Contributor Author

heguanhui commented Jan 24, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 24, 2026

TPC-H: Total hot run time: 31108 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2cc7f10cbec42bb0accae531d9462ee76cf1c19f, data reload: false

------ Round 1 ----------------------------------
q1	17628	4708	4534	4534
q2	2003	306	192	192
q3	10255	1304	721	721
q4	10208	836	304	304
q5	7527	2104	1853	1853
q6	186	170	137	137
q7	849	725	582	582
q8	9283	1326	1111	1111
q9	4823	4617	4653	4617
q10	6787	1651	1281	1281
q11	521	283	292	283
q12	333	380	226	226
q13	17766	3843	3050	3050
q14	229	235	223	223
q15	600	547	526	526
q16	661	623	579	579
q17	650	804	475	475
q18	6623	6344	6629	6344
q19	1291	1043	633	633
q20	404	383	273	273
q21	2968	2125	2229	2125
q22	1158	1108	1039	1039
Total cold run time: 102753 ms
Total hot run time: 31108 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4928	4863	5041	4863
q2	330	402	321	321
q3	2382	2819	2448	2448
q4	1481	1923	1433	1433
q5	4530	4495	4273	4273
q6	226	171	128	128
q7	2133	2061	1866	1866
q8	2550	2393	2385	2385
q9	7130	7085	7082	7082
q10	2606	2682	2334	2334
q11	526	464	439	439
q12	642	707	569	569
q13	3312	3795	3044	3044
q14	286	279	265	265
q15	534	496	492	492
q16	640	642	601	601
q17	1085	1296	1347	1296
q18	7498	7307	7330	7307
q19	804	788	797	788
q20	1868	1968	1809	1809
q21	4448	4218	4178	4178
q22	1094	1033	967	967
Total cold run time: 51033 ms
Total hot run time: 48888 ms

@doris-robot
Copy link

doris-robot commented Jan 24, 2026

TPC-DS: Total hot run time: 172500 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2cc7f10cbec42bb0accae531d9462ee76cf1c19f, data reload: false

query5	4517	635	492	492
query6	328	215	201	201
query7	4215	451	254	254
query8	327	250	241	241
query9	8753	2855	2857	2855
query10	464	306	281	281
query11	15516	15017	14834	14834
query12	171	117	115	115
query13	1241	481	393	393
query14	6326	3010	2824	2824
query14_1	2758	2670	2656	2656
query15	197	188	171	171
query16	985	487	455	455
query17	1093	672	568	568
query18	2442	429	326	326
query19	200	184	152	152
query20	130	122	118	118
query21	218	137	121	121
query22	4128	4087	3878	3878
query23	16081	15577	15311	15311
query23_1	15581	15476	15667	15476
query24	7137	1564	1176	1176
query24_1	1142	1166	1170	1166
query25	557	456	410	410
query26	1235	272	158	158
query27	2754	444	277	277
query28	4576	2151	2162	2151
query29	768	544	449	449
query30	315	247	208	208
query31	786	619	558	558
query32	85	74	78	74
query33	542	355	324	324
query34	901	877	528	528
query35	721	742	666	666
query36	890	848	862	848
query37	141	103	94	94
query38	2672	2728	2629	2629
query39	784	769	760	760
query39_1	700	727	723	723
query40	217	136	121	121
query41	72	69	66	66
query42	101	96	95	95
query43	464	440	398	398
query44	1331	747	747	747
query45	189	190	179	179
query46	834	941	605	605
query47	1530	1430	1347	1347
query48	303	313	236	236
query49	598	418	335	335
query50	673	278	213	213
query51	3760	3705	3780	3705
query52	92	88	79	79
query53	216	219	172	172
query54	266	250	236	236
query55	77	78	74	74
query56	287	286	296	286
query57	1021	1013	956	956
query58	268	260	257	257
query59	2105	2009	2093	2009
query60	341	334	306	306
query61	144	145	138	138
query62	368	340	312	312
query63	195	163	162	162
query64	4779	1152	840	840
query65	3799	3704	3727	3704
query66	1452	418	308	308
query67	15527	15568	15357	15357
query68	2417	1054	744	744
query69	418	304	279	279
query70	997	958	957	957
query71	301	286	261	261
query72	5288	3139	3195	3139
query73	596	717	317	317
query74	8688	8766	8525	8525
query75	2276	2328	1921	1921
query76	2282	1041	635	635
query77	368	373	290	290
query78	9732	9678	9167	9167
query79	2705	905	592	592
query80	1730	524	435	435
query81	534	260	226	226
query82	989	147	118	118
query83	316	259	242	242
query84	251	115	91	91
query85	864	466	405	405
query86	408	292	307	292
query87	2858	2847	2794	2794
query88	3460	2592	2577	2577
query89	306	258	248	248
query90	1937	167	167	167
query91	163	159	130	130
query92	71	78	68	68
query93	1225	1012	653	653
query94	643	301	293	293
query95	573	369	309	309
query96	657	506	233	233
query97	2366	2414	2328	2328
query98	234	221	194	194
query99	587	552	510	510
Total cold run time: 249131 ms
Total hot run time: 172500 ms

@doris-robot
Copy link

doris-robot commented Jan 24, 2026

ClickBench: Total hot run time: 27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2cc7f10cbec42bb0accae531d9462ee76cf1c19f, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.27	0.26
query6	1.15	0.66	0.65
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.55	0.55	0.54
query11	0.14	0.10	0.10
query12	0.13	0.10	0.11
query13	0.61	0.58	0.59
query14	0.96	0.94	0.94
query15	0.79	0.79	0.79
query16	0.40	0.39	0.42
query17	1.00	0.98	1.02
query18	0.24	0.21	0.21
query19	1.86	1.80	1.84
query20	0.02	0.01	0.01
query21	15.44	0.25	0.13
query22	5.32	0.05	0.05
query23	16.20	0.29	0.10
query24	1.11	0.50	1.59
query25	0.10	0.14	0.05
query26	0.13	0.14	0.13
query27	0.07	0.05	0.06
query28	5.26	1.05	0.88
query29	12.61	3.89	3.19
query30	0.28	0.14	0.12
query31	2.81	0.63	0.39
query32	3.25	0.55	0.46
query33	2.97	3.11	3.00
query34	16.09	5.09	4.44
query35	4.43	4.48	4.49
query36	0.64	0.49	0.48
query37	0.10	0.06	0.07
query38	0.06	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.02 s
Total hot run time: 27 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 24, 2026

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 24, 2026

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@heguanhui heguanhui force-pushed the bugfix/fix-query-fields-error-with-frontends-udf branch from cb4f538 to 069d850 Compare January 25, 2026 03:17
@heguanhui
Copy link
Contributor Author

heguanhui commented Jan 25, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 25, 2026

TPC-H: Total hot run time: 31137 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 069d850e19236bbc6a971daf9f3c9964628e5e1e, data reload: false

------ Round 1 ----------------------------------
q1	17779	4758	4576	4576
q2	2058	348	187	187
q3	10248	1272	715	715
q4	10223	801	313	313
q5	7518	2040	1834	1834
q6	182	170	143	143
q7	849	735	604	604
q8	9275	1346	1038	1038
q9	4845	4622	4490	4490
q10	6853	1651	1267	1267
q11	532	302	268	268
q12	358	376	219	219
q13	17802	3887	3180	3180
q14	253	239	211	211
q15	597	530	523	523
q16	654	655	587	587
q17	675	797	513	513
q18	6864	6520	6948	6520
q19	1168	1050	686	686
q20	416	364	258	258
q21	2901	2267	1971	1971
q22	1125	1090	1034	1034
Total cold run time: 103175 ms
Total hot run time: 31137 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4946	4991	5046	4991
q2	354	418	327	327
q3	2520	2868	2517	2517
q4	1493	1840	1476	1476
q5	4782	4405	4544	4405
q6	215	169	130	130
q7	2107	2001	1914	1914
q8	2606	2520	2435	2435
q9	7239	7524	7246	7246
q10	2547	2799	2300	2300
q11	545	464	467	464
q12	702	738	565	565
q13	3373	3831	3107	3107
q14	269	283	262	262
q15	537	503	501	501
q16	614	652	604	604
q17	1084	1226	1279	1226
q18	7599	7345	7384	7345
q19	822	772	795	772
q20	1910	1972	1822	1822
q21	4428	4229	4146	4146
q22	1042	1021	973	973
Total cold run time: 51734 ms
Total hot run time: 49528 ms

@doris-robot
Copy link

doris-robot commented Jan 25, 2026

TPC-DS: Total hot run time: 172222 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 069d850e19236bbc6a971daf9f3c9964628e5e1e, data reload: false

query5	4749	622	504	504
query6	333	229	199	199
query7	4210	452	255	255
query8	337	250	238	238
query9	8763	2836	2872	2836
query10	476	319	297	297
query11	15337	15022	14817	14817
query12	181	119	116	116
query13	1253	457	353	353
query14	6367	3122	2747	2747
query14_1	2710	2614	2653	2614
query15	205	189	174	174
query16	993	465	379	379
query17	1072	677	577	577
query18	2576	423	333	333
query19	195	175	155	155
query20	129	114	121	114
query21	218	149	120	120
query22	3779	4105	3804	3804
query23	15977	15560	15307	15307
query23_1	15479	15544	15581	15544
query24	7183	1549	1148	1148
query24_1	1154	1147	1180	1147
query25	534	438	380	380
query26	1237	270	145	145
query27	2760	442	273	273
query28	4565	2147	2135	2135
query29	773	515	414	414
query30	299	235	213	213
query31	818	628	549	549
query32	87	75	74	74
query33	503	350	301	301
query34	886	905	537	537
query35	721	752	684	684
query36	849	872	863	863
query37	142	96	91	91
query38	2687	2626	2681	2626
query39	761	750	722	722
query39_1	696	736	703	703
query40	221	129	116	116
query41	65	62	61	61
query42	95	95	90	90
query43	477	467	414	414
query44	1315	742	735	735
query45	191	185	175	175
query46	826	935	574	574
query47	1382	1451	1350	1350
query48	316	319	234	234
query49	594	418	336	336
query50	663	262	203	203
query51	3741	3822	3786	3786
query52	94	89	81	81
query53	228	225	170	170
query54	273	255	245	245
query55	80	79	77	77
query56	305	289	291	289
query57	1035	1025	897	897
query58	268	254	255	254
query59	2048	2166	2025	2025
query60	330	327	318	318
query61	145	144	146	144
query62	395	350	315	315
query63	192	165	159	159
query64	4916	1124	877	877
query65	3825	3725	3774	3725
query66	1414	414	311	311
query67	15574	15651	15732	15651
query68	2430	1043	723	723
query69	393	317	278	278
query70	989	951	908	908
query71	300	285	271	271
query72	5282	3099	3308	3099
query73	582	716	307	307
query74	8748	8839	8561	8561
query75	2293	2328	1873	1873
query76	2274	1069	641	641
query77	353	364	285	285
query78	9598	9850	9124	9124
query79	1070	887	572	572
query80	608	521	462	462
query81	456	260	228	228
query82	1330	153	119	119
query83	353	258	234	234
query84	259	110	100	100
query85	800	467	414	414
query86	359	290	292	290
query87	2888	2816	2825	2816
query88	3452	2587	2567	2567
query89	295	267	247	247
query90	1859	173	165	165
query91	157	160	133	133
query92	75	74	73	73
query93	1034	1072	636	636
query94	494	297	290	290
query95	568	337	373	337
query96	654	492	228	228
query97	2339	2353	2291	2291
query98	212	202	198	198
query99	599	579	511	511
Total cold run time: 245159 ms
Total hot run time: 172222 ms

@doris-robot
Copy link

doris-robot commented Jan 25, 2026

ClickBench: Total hot run time: 26.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 069d850e19236bbc6a971daf9f3c9964628e5e1e, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.09	0.08
query4	1.61	0.11	0.11
query5	0.29	0.26	0.26
query6	1.14	0.66	0.66
query7	0.02	0.03	0.03
query8	0.06	0.05	0.04
query9	0.57	0.49	0.50
query10	0.54	0.53	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.58	0.58
query14	0.95	0.95	0.95
query15	0.80	0.78	0.79
query16	0.37	0.41	0.39
query17	1.04	1.06	1.06
query18	0.23	0.22	0.21
query19	1.89	1.79	1.87
query20	0.02	0.02	0.02
query21	15.40	0.27	0.13
query22	5.15	0.05	0.05
query23	15.90	0.28	0.10
query24	1.70	0.48	0.18
query25	0.07	0.05	0.06
query26	0.13	0.13	0.13
query27	0.07	0.04	0.07
query28	3.76	1.08	0.88
query29	12.52	3.90	3.19
query30	0.28	0.14	0.11
query31	2.83	0.64	0.39
query32	3.24	0.59	0.46
query33	3.02	3.05	3.03
query34	16.35	5.04	4.43
query35	4.51	4.50	4.46
query36	0.65	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 96.96 s
Total hot run time: 26.76 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 25, 2026

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@morningman morningman self-assigned this Jan 26, 2026
morningman
morningman reviewed Jan 26, 2026
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/tablefunction/FrontendsTableValuedFunction.java
new Column("Version", ScalarType.createStringType()),
new Column("CurrentConnected", ScalarType.createStringType()));
new Column("CurrentConnected", ScalarType.createStringType()),
new Column("LiveSince", ScalarType.createStringType())
Copy link
Contributor

@morningman morningman Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should directly use FrontendsProcNode.TITLE_NAMES to create this SCHEMA, so that we will not miss any in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@morningman morningman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heguanhui @hello-stephen @doris-robot @morningman