You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Rule EliminateNotNull because it may causes mistaken deletion.
Step as follow:
for expression E1
rule InferNotNull rewrite E1, got E2 = E1 and a is not null
some rule may simplify E2, then got E3 = a is not null
rule EliminateNotNull remove the generated expression a is not null, and got E4=TRUE.
then it will have E1 => TRUE, this have bug. For rule InferNotNull, we know that E1 will evaluate to NULL/FALSE when a is null, so E1 cannot always evaluate to true.
This PR also remove field isGeneratedIsNotNull for NOT.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Rule EliminateNotNull because it may causes mistaken deletion.
Step as follow:
for expression E1
E2 = E1 and a is not nullE3 = a is not nulla is not null, and gotE4=TRUE.then it will have E1 => TRUE, this have bug. For rule InferNotNull, we know that E1 will evaluate to NULL/FALSE when a is null, so E1 cannot always evaluate to true.
This PR also remove field isGeneratedIsNotNull for NOT.
related PR: #16411
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)