-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](insert) fix insert failed when concurrent schema change #60182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31145 ms |
TPC-DS: Total hot run time: 171575 ms |
ClickBench: Total hot run time: 26.74 s |
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
fix insert failed when concurrent schema change because the lock scope is small, introduced by #45045. ``` 2025-12-22 18:31:27,916 WARN (mysql-nio-pool-20|395) [StmtExecutor.execute():546] Analyze failed. stmt[223, 6daf515a262f4708-959e9e3ef4590797] org.apache.doris.common.NereidsException: errCode = 2, detailMessage = insert into cols should be corresponding to the query output at org.apache.doris.qe.StmtExecutor.executeByNereids(StmtExecutor.java:706) at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:541) at org.apache.doris.qe.StmtExecutor.queryRetry(StmtExecutor.java:500) at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:485) at org.apache.doris.qe.ConnectProcessor.executeQuery(ConnectProcessor.java:311) at org.apache.doris.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:198) at org.apache.doris.qe.MysqlConnectProcessor.handleQuery(MysqlConnectProcessor.java:231) at org.apache.doris.qe.MysqlConnectProcessor.dispatch(MysqlConnectProcessor.java:259) at org.apache.doris.qe.MysqlConnectProcessor.processOnce(MysqlConnectProcessor.java:403) at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = insert into cols should be corresponding to the query output ... 13 more Caused by: org.apache.doris.nereids.exceptions.AnalysisException: insert into cols should be corresponding to the query output at org.apache.doris.nereids.rules.analysis.BindSink.bindOlapTableSink(BindSink.java:194) at org.apache.doris.nereids.pattern.PatternMatcher$1.transform(PatternMatcher.java:96) at org.apache.doris.nereids.jobs.rewrite.TopDownVisitorRewriteJob.doRewrite(TopDownVisitorRewriteJob.java:114) at org.apache.doris.nereids.jobs.rewrite.TopDownVisitorRewriteJob.rewrite(TopDownVisitorRewriteJob.java:80) at org.apache.doris.nereids.jobs.rewrite.TopDownVisitorRewriteJob.execute(TopDownVisitorRewriteJob.java:56) at org.apache.doris.nereids.jobs.rewrite.AdaptiveTopDownRewriteJob.execute(AdaptiveTopDownRewriteJob.java:41) at org.apache.doris.nereids.jobs.executor.AbstractBatchJobExecutor.execute(AbstractBatchJobExecutor.java:167) at org.apache.doris.nereids.jobs.executor.Analyzer.lambda$execute$0(Analyzer.java:98) at org.apache.doris.nereids.util.MoreFieldsThread.keepFunctionSignature(MoreFieldsThread.java:127) at org.apache.doris.nereids.jobs.executor.Analyzer.execute(Analyzer.java:97) at org.apache.doris.nereids.jobs.executor.Analyzer.analyze(Analyzer.java:92) at org.apache.doris.nereids.NereidsPlanner.lambda$analyze$4(NereidsPlanner.java:414) at org.apache.doris.nereids.NereidsPlanner.keepOrShowPlanProcess(NereidsPlanner.java:1109) at org.apache.doris.nereids.NereidsPlanner.analyze(NereidsPlanner.java:414) at org.apache.doris.nereids.trees.plans.commands.insert.FastInsertIntoValuesPlanner.analyze(FastInsertIntoValuesPlanner.java:63) at org.apache.doris.nereids.NereidsPlanner.planWithoutLock(NereidsPlanner.java:288) at org.apache.doris.nereids.NereidsPlanner.planWithLock(NereidsPlanner.java:263) at org.apache.doris.nereids.NereidsPlanner.plan(NereidsPlanner.java:162) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.planInsertExecutor(InsertIntoTableCommand.java:540) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.initPlanOnce(InsertIntoTableCommand.java:353) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.initPlan(InsertIntoTableCommand.java:259) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.initPlan(InsertIntoTableCommand.java:226) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.runInternal(InsertIntoTableCommand.java:569) at org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand.run(InsertIntoTableCommand.java:210) at org.apache.doris.qe.StmtExecutor.executeByNereids(StmtExecutor.java:678) ... 12 more ```
What problem does this PR solve?
fix insert failed when concurrent schema change because the lock scope is small, introduced by #45045.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)