fix: parquet limit pruning for row group selections#22942
Merged
Conversation
Contributor
Author
|
Thanks @xudong963 |
haohuaijin
added a commit
to openobserve/datafusion
that referenced
this pull request
Jun 18, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#22941 ## Rationale for this change Limit pruning handled row groups with `RowSelection` incorrectly. It counted the full row group size and could replace a selection with a full scan. ## What changes are included in this PR? - Preserve existing row selections. - Count only selected rows when checking the limit. - Add regression tests for both cases. ## Are these changes tested? Yes. New unit tests cover preserving `RowSelection` and counting selected rows during limit pruning. ## Are there any user-facing changes? No API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowSelection#22941Rationale for this change
Limit pruning handled row groups with
RowSelectionincorrectly. It counted the full row group size and could replace a selection with a full scan.What changes are included in this PR?
Are these changes tested?
Yes. New unit tests cover preserving
RowSelectionand counting selected rows during limit pruning.Are there any user-facing changes?
No API changes.