Refactor Spark format_string numeric %c conversion dispatch#22166
Draft
kosiew wants to merge 2 commits into
Draft
Refactor Spark format_string numeric %c conversion dispatch#22166kosiew wants to merge 2 commits into
format_string numeric %c conversion dispatch#22166kosiew wants to merge 2 commits into
Conversation
…ction - Implemented integer_scalar_to_char(&ScalarValue) in format_string.rs - Routed all integer %c cases through the new helper function - Preserved null handling and support for other integer formats
- Updated function signature from integer_scalar_to_char(value) to integer_scalar_to_char(scalar) - Added a centralized non-null integer %c dispatch arm - Removed 8 redundant %c dispatch arms - Removed 8 scalar @ bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
%cformatting dispatch in format_string.rs #22163Rationale for this change
The
%cconversion path in Sparkformat_stringduplicated nearly identical logic across all signed and unsigned integer scalar variants. This duplication increased maintenance overhead and the risk of future%cfixes being applied inconsistently.This change centralizes numeric scalar-to-character conversion in a single helper while preserving existing behavior and error propagation semantics.
What changes are included in this PR?
integer_scalar_to_charhelper to centralize integer scalar%cconversion handling.%cconversion paths through the new helper.%cconversion branches from individual integer scalar match arms.signed_to_charandunsigned_to_charhelpers.%cformatting behavior unchanged.Are these changes tested?
No new tests were added in this PR.
This refactor is intended to preserve existing behavior, and existing
%cformatting tests continue to validate valid and invalid code point handling.Suggested validation command:
cargo test -p datafusion-spark format_charAre there any user-facing changes?
No. This is a maintainability refactor only and is not intended to change observable behavior or error messages.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed and tested.