Skip to content

Conversation

@manuzhang
Copy link
Member

@manuzhang manuzhang commented Dec 13, 2025

Which issue does this PR close?

Part of #2766

Rationale for this change

What changes are included in this PR?

  1. Implement tests for cast array to array
  2. Fix casting array to array for some element types.

How are these changes tested?

Added tests.

@manuzhang manuzhang force-pushed the test-array-cast branch 4 times, most recently from 864a25f to 92a7867 Compare December 14, 2025 15:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.53%. Comparing base (f09f8af) to head (5f7b017).
⚠️ Report is 815 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2897      +/-   ##
============================================
+ Coverage     56.12%   59.53%   +3.40%     
- Complexity      976     1376     +400     
============================================
  Files           119      167      +48     
  Lines         11743    15496    +3753     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9225    +2634     
- Misses         4012     4971     +959     
- Partials       1140     1300     +160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@manuzhang
Copy link
Member Author

Created #2914 for the failed test

  "...The value -96833550.[]7BD of the type "DEC..." did not equal "...The value -96833550.[0]7BD of the type "DEC..." (CometCastSuite.scala:1328)

@manuzhang
Copy link
Member Author

Submitted #2916 to fix the failed test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants