Update configure with the latest configure.ac#1650
Update configure with the latest configure.ac#1650tuhaihe wants to merge 1 commit intoapache:mainfrom
Conversation
Some changes to configure.ac have been made by the following PRs: - apache#1598 - apache#1363 We need to regenerate the `configure` file by the command `autoconf`, not simply editing the configure directly. This commit is to generate the latest configure based the latest configure.ac. OS: Rocky Linux 8 Autoconf: 2.69 (default version in Rocky Linux 8)
|
|
||
| else | ||
| with_mdblocales=no | ||
| with_mdblocales=yes |
There was a problem hiding this comment.
Does it enable mdb_locales by default? If yes, it's bad. It's needed an additional package with custom locales (individual for every installation). For example, one installation could have a frozen libc since Rocky Linux 8 and not change the symbol orders anymore. The second could have a frozen libc in Rocky Linux 9, and so on. I prefer not to enable it. Let's do not give custom locales for users by default, it's only for those who fully understand what it is about.
There was a problem hiding this comment.
Based on the commit history, mdblocales has been enabled by default. The configure file in this PR was generated from the current configure.ac using autoconf, which reflects the existing default setting.
I agree with your concern about disabling mdblocales by default. Since this PR is focused on regenerating the configure file from configure.ac, how about we create a separate PR to change the default behavior of mdblocales? That way we can discuss and review the default setting change independently.
What do you think?
There was a problem hiding this comment.
I created a PR on disabling the mdblocales by default: #1651
There was a problem hiding this comment.
Yes, this has been done by mistake, let's fix it in another PR
|
Will use #1651. Close this PR. |
2 participants
Some changes to configure.ac have been made by the following PRs:
We need to regenerate the
configurefile by the commandautoconf, not simply editing the configure directly. This commit is to generate the latest configure based the latest configure.ac.OS: Rocky Linux 8
Autoconf: 2.69 (default version in Rocky Linux 8)
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions