Fix ORCA permission checking crash for ROLLUP + window function queries#1643
Draft
lss602726449 wants to merge 8 commits intoapache:cbdb-postgres-mergefrom
Draft
Fix ORCA permission checking crash for ROLLUP + window function queries#1643lss602726449 wants to merge 8 commits intoapache:cbdb-postgres-mergefrom
lss602726449 wants to merge 8 commits intoapache:cbdb-postgres-mergefrom
Conversation
lss602726449
force-pushed
the
fix_orca_perminfo
branch
2 times, most recently
from
4a21dfc to
f2c27eb
Compare
added 4 commits
March 30, 2026 18:27
1. orca.c: transformGroupedWindows() incorrectly created an RTEPermissionInfo with relid=0 for a subquery RTE. Per PG16 commit a61b1f7, only RTE_RELATION entries need RTEPermissionInfo. This caused Assert(OidIsValid(perminfo->relid)) failure when ORCA translated ROLLUP + window function queries. 2. matview.c: replace_rte_with_delta() converted RTE_RELATION to RTE_SUBQUERY but forgot to clear perminfoindex, causing Assert(rte->rtekind == RTE_RELATION || ...) failure during IVM incremental maintenance with ORCA enabled. Also fix subquery not inheriting rteperminfos, and correct AddPerfmInfo/Perfission typos.
BuildForeignScan() calls build_simple_rel() which looks up RTEPermissionInfo via root->parse->rteperminfos using the RTE's perminfoindex. When ORCA translates DXL back to a PlannedStmt, it creates new RTEs with its own perminfoindex numbering, but passes m_orig_query (the rewritten query) to BuildForeignScan. After the rewriter expands external table ON SELECT rules into subqueries, the outer query's rteperminfos shrinks, causing a mismatch: e.g. perminfoindex=2 but rteperminfos has only 1 entry. Fix by temporarily swapping m_orig_query->rteperminfos with ORCA's own perminfos list around CreateForeignScan calls, so the indices are consistent. This covers both static and dynamic foreign scans.
Contributor
|
I am +1 on 9cba113 |
added 2 commits
March 31, 2026 10:46
lss602726449
force-pushed
the
fix_orca_perminfo
branch
from
f2c27eb to
36bf76c
Compare
added 2 commits
March 31, 2026 18:10
lss602726449
force-pushed
the
fix_orca_perminfo
branch
from
76a83a1 to
5c88c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformGroupedWindows() incorrectly created an RTEPermissionInfo with relid=0 for a subquery RTE. Per PG16 commit a61b1f7, only RTE_RELATION entries need RTEPermissionInfo. This caused Assert(OidIsValid(perminfo->relid)) failure in ExecCheckPermissions when ORCA translated the query.
Also fix subquery not inheriting rteperminfos from the original query, and correct AddPerfmInfo/Perfission typos.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions