fix(consumer): makes the username field read-only on the consumer edit page#3396
Open
okaybase wants to merge 3 commits into
Open
fix(consumer): makes the username field read-only on the consumer edit page#3396okaybase wants to merge 3 commits into
okaybase wants to merge 3 commits into
Conversation
Baoyuantop
reviewed
May 28, 2026
Contributor
Baoyuantop
left a comment
Baoyuantop
left a comment
There was a problem hiding this comment.
Please add coverage for cases: the username input is read-only in Consumer detail edit mode page.
Member
Author
tests added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
username is the unique identifier of the Consumer. When editing the Consumer, username should not be editable. Currently, it can be edited and saved to create a new Consumer.
What changes will this PR take into?
This PR makes the username field read-only on the consumer edit page.
Checklist: