Monitor and Message improvments, include Tablet Recovery information#6356
Open
dlmarion wants to merge 3 commits intoapache:mainfrom
Open
Monitor and Message improvments, include Tablet Recovery information#6356dlmarion wants to merge 3 commits intoapache:mainfrom
dlmarion wants to merge 3 commits intoapache:mainfrom
Conversation
dlmarion
commented
May 1, 2026
| if (!compactors.containsKey(rg.canonical()) && !sservers.containsKey(rg.canonical()) | ||
| && !tservers.containsKey(rg.canonical())) { | ||
| addMessage(Info, Configuration, "Resource Group " + rg | ||
| + " exists, but no resources assigned. Consider removing the resource group"); |
Contributor
Author
There was a problem hiding this comment.
Created #6357 for a related issue. Could suggest how to do it in this message.
Prior to this change the InformationFetcher would create a new instance of a SystemInformation object while the Monitor UI would display the last SystemInformation object. If any of the tasks to create the new SystemInformation object failed, then the Monitor would continue to display the old information. With this change the new SystemInformation object is always used, and if it's incomplete then a new message is shown on the Messages page. This change also includes a new computeMessages method that is called from SystemInformation.finish. This method includes new messages that use new priorities and categories. Finally, this change introduces a new Tablet Recoveries page in the Activity menu. Information for this page is gathered from metrics emitted by the server processes and information in the tablet metadata. Closes apache#6306, apache#6106
dlmarion
force-pushed
the
monitor-message-updates
branch
from
06a25da to
04494c1
Compare
dlmarion
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the InformationFetcher would create a new
instance of a SystemInformation object while the Monitor UI
would display the last SystemInformation object. If any of the
tasks to create the new SystemInformation object failed, then
the Monitor would continue to display the old information.
With this change the new SystemInformation object is always
used, and if it's incomplete then a new message is shown on
the Messages page.
This change also includes a new computeMessages method that
is called from SystemInformation.finish. This method includes
new messages that use new priorities and categories.
Finally, this change introduces a new Tablet Recoveries page
in the Activity menu. Information for this page is gathered
from metrics emitted by the server processes and information
in the tablet metadata.
Closes #6306, #6106