Update ecog visualization - #745
Open
ajm2605 wants to merge 5 commits into
Open
Conversation
leoscholl
reviewed
Mar 18, 2026
| raise ValueError("annotation_style must be either 'text' or 'marker'.") | ||
|
|
||
| def annotate_spatial_map_channels(acq_idx=None, acq_ch=None, drive_type='ECoG244', theta=0, color='k', | ||
| def annotate_spatial_map_channels(acq_idx=None, acq_ch=None, electrode_idx=None, labels=None, drive_type='ECoG244', theta=0, color='k', |
Collaborator
There was a problem hiding this comment.
can you add a description for labels in the docstring?
leoscholl
reviewed
Mar 18, 2026
Comment on lines
+886
to
+888
| electrode_idx ((electrode_idx,) array or list, optional): If provided, specifies the electrode IDs (0-indexed) to | ||
| be annotated. Only the specified electrodes will be annotated, labeled by their electrode ID. | ||
| If neither acq_idx, acq_ch, nor elecs is provided, all channel numbers will be annotated by default. |
Collaborator
There was a problem hiding this comment.
could say that the electrode_idx indexes into acq_ch? or is that confusing...
and/or maybe give an example of indexing into 240 ecog electrodes?
Collaborator
Author
There was a problem hiding this comment.
Does this sort of better explain what is happening?
leoscholl
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.