fix(config): update in-memory session config when setting default model#2880
Open
nocmk2 wants to merge 3 commits intoantinomyhq:mainfrom
Open
fix(config): update in-memory session config when setting default model#2880nocmk2 wants to merge 3 commits intoantinomyhq:mainfrom
nocmk2 wants to merge 3 commits intoantinomyhq:mainfrom
Conversation
…vider and model set_default_provider_and_model() only persisted the new provider/model to disk via update_environment() but did not update the in-memory self.config. This caused subsequent get_default_model() and get_default_provider() calls within the same process to return stale values. After switching models via /model (which crosses providers), the TUI and zsh rprompt would still show the old model until the process was restarted. Now the in-memory config is updated immediately after the disk write, matching the behavior of set_default_model() and set_default_provider(). Co-Authored-By: ForgeCode <noreply@forgecode.dev>
|
|
github-actions
bot
added
the
type: fix
- Resolving conflict in crates/forge_services/src/app_config.rs by accepting upstream's new infrastructure-based configuration service architecture. - Replaced local Mutex-based session state management with update_config operations. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
- Added 'forge paste-image' subcommand to save clipboard images and output @[path]. - Added /paste-image (/pv) REPL command to save image and add to prompt buffer. - Added Ctrl-X Ctrl-V shortcut to ZSH plugin for easy image pasting. - Integrated with arboard and image crates for cross-platform support. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_default_provider_and_model() only persisted the new provider/model to disk via update_environment() but did not update the in-memory self.config. This caused subsequent get_default_model() and get_default_provider() calls within the same process to return stale values.
After switching models via /model (which crosses providers), the TUI and zsh rprompt would still show the old model until the process was restarted. Now the in-memory config is updated immediately after the disk write, matching the behavior of set_default_model() and set_default_provider().