nf: derive --organism from params.genome, gate ARDA on supported assemblies - #76
Merged
Conversation
…mblies (closes #75) Requested in #75: run ARDA only on assemblies arda has a reference for, and set --organism from the assembly rather than hardcoding it. The module's main.nf already honours `task.ext.when` (its `when:` block) and `task.ext.args`, so this is entirely in the module's nextflow.config: ext.when = { params.genome in ['GRCh38', 'GRCm39'] } ext.args = { GRCh38 -> --organism human ; GRCm39 -> --organism mouse ; else '' } `params.genome` is the iGenomes key nf-core sets from --genome, so ARDA follows whatever assembly the rest of the pipeline runs on with no extra parameter. Any other genome (or none) skips ARDA and the pipeline still completes. Verified end-to-end on aldan3 (Nextflow 21.10.6) with the real module and a fake `arda` on PATH that records its argv: --genome GRCh38 -> ARDA runs, receives --organism human --genome GRCm39 -> ARDA runs, receives --organism mouse --genome GRCh37 -> ARDA skipped, no error (no --genome) -> ARDA skipped, no error Docs (module README + pipeline_integration.rst) document the mapping and that a static ext.args string overrides the genome-driven default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75.
@EgorGuga requested that the Nextflow module's
nextflow.config:params.genomeisGRCh38orGRCm39, and--organismtohuman/mousefrom the assembly.The module's
main.nfalready honours both hooks this needs —task.ext.when(itswhen:block) andtask.ext.args— so the change is entirely in the config, no module edit:params.genomeis the iGenomes key nf-core sets from--genome, so ARDA follows whatever assembly the rest of the pipeline is already running on — nothing extra to configure. Any other genome (or none) skips ARDA and the pipeline still completes.Verified end-to-end (not just parsed)
On aldan3 with real Nextflow (21.10.6), the real module + this config, and a fake
ardaon PATH that records its argv:--genome--organismreceivedGRCh38humanGRCm39mouseGRCh37The skipped cases complete with no error; the two supported cases publish all four output files.
Docs updated (module
README.md+pipeline_integration.rst): the genome→organism mapping, and that a staticext.argsstring overrides the genome-driven default. Sphinx-Wbuild clean.