-
Notifications
You must be signed in to change notification settings - Fork 686
fix: route Bedrock SSE error events to the error handler #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xodn348
wants to merge
1
commit into
anthropics:main
Choose a base branch
from
xodn348:fix/issue-1472
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import json | ||
|
|
||
| from anthropic.lib.bedrock._stream_decoder import AWSEventStreamDecoder | ||
|
|
||
|
|
||
| class TestGetSseEventType: | ||
| def test_error_event_returns_error(self) -> None: | ||
| decoder = _make_decoder() | ||
| message = json.dumps( | ||
| { | ||
| "type": "error", | ||
| "error": {"type": "rate_limit_error", "message": "Rate limited", "details": None}, | ||
| "request_id": "req_123", | ||
| } | ||
| ) | ||
| assert decoder._get_sse_event_type(message) == "error" | ||
|
|
||
| def test_message_start_event_returns_completion(self) -> None: | ||
| decoder = _make_decoder() | ||
| message = json.dumps( | ||
| { | ||
| "type": "message_start", | ||
| "message": { | ||
| "id": "msg_123", | ||
| "type": "message", | ||
| "role": "assistant", | ||
| "content": [], | ||
| "model": "claude-opus-4-7", | ||
| "stop_reason": None, | ||
| "stop_sequence": None, | ||
| "usage": {"input_tokens": 10, "output_tokens": 0}, | ||
| }, | ||
| } | ||
| ) | ||
| assert decoder._get_sse_event_type(message) == "completion" | ||
|
|
||
| def test_content_block_delta_returns_completion(self) -> None: | ||
| decoder = _make_decoder() | ||
| message = json.dumps( | ||
| { | ||
| "type": "content_block_delta", | ||
| "index": 0, | ||
| "delta": {"type": "text_delta", "text": "Hello"}, | ||
| } | ||
| ) | ||
| assert decoder._get_sse_event_type(message) == "completion" | ||
|
|
||
| def test_invalid_json_returns_completion(self) -> None: | ||
| decoder = _make_decoder() | ||
| assert decoder._get_sse_event_type("not json") == "completion" | ||
|
|
||
| def test_non_dict_json_returns_completion(self) -> None: | ||
| decoder = _make_decoder() | ||
| assert decoder._get_sse_event_type('"just a string"') == "completion" | ||
|
|
||
| def test_dict_without_type_returns_completion(self) -> None: | ||
| decoder = _make_decoder() | ||
| assert decoder._get_sse_event_type('{"foo": "bar"}') == "completion" | ||
|
|
||
|
|
||
| def _make_decoder() -> AWSEventStreamDecoder: | ||
| return AWSEventStreamDecoder() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when it raises
ValueErrororKeyError? I think the only error the code above can raise it'sjson.decoder.JSONDecodeErrorduringjson.loads(message)