fix(compaction): use neutral text for compaction replay message#13940
Open
leohenon wants to merge 1 commit intoanomalyco:devfrom
Open
fix(compaction): use neutral text for compaction replay message#13940leohenon wants to merge 1 commit intoanomalyco:devfrom
leohenon wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where compaction replay injected a synthetic user prompt (“What did we do so far?”) that could trigger unintended model summaries, replacing it with a neutral marker.
Changes:
- Replaced the compaction replay injected user text with
"[Compacted]". - Updated the corresponding unit test expectation in
message-v2.test.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/opencode/src/session/message-v2.ts | Updates the synthetic compaction text injected into user model messages to a neutral marker. |
| packages/opencode/test/session/message-v2.test.ts | Updates test expectations to match the new injected compaction marker text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #13838
Compaction injects
What did we do so far?as a user message. The model treats this as a real request and sometimes generates an unwanted summary.Changed the text to
[Compacted].How did you verify your code works?
Updated test in
message-v2.test.tsand verified manually.