fix: keep oversized tool results out of model context - #647
Open
naliazheli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TurnEnginecurrently serializes every successful tool result directly into model history. A single large browser/computer snapshot, MCP response, database result, or log can therefore consume the remaining context window before compaction gets a chance to run. In a reproduced case, one snapshot returned more than 100k characters and the next provider request failed.This is a runtime boundary problem rather than a computer-use-specific problem: every registered tool currently reaches the same unbounded
_tool_result_messagepath.Changes
TurnEngine._record_result.openworker/tool-results/directoryresult_ref, size, and SHA-256read_tool_resultfor exact, paged retrievalSmall tool results preserve their current shape and behavior.
Relationship to #67
#67 addresses the same core problem and includes a broader session-scoped design, including shell capture, server/UI retrieval, ACL handling, and lifecycle cleanup. At the time of this PR it is 288 commits behind
mainand has merge conflicts.This PR is intentionally a smaller current-
mainimplementation focused on protecting the model context for all ordinary tool results. I am happy for maintainers to prefer a refreshed #67 or combine the approaches; this PR explicitly credits that prior work and does not claim its broader scope.Validation
example.comandshort.linkto the198.18.0.0/15private benchmark range; the same 3 failures reproduce unchanged onorigin/main@7fc3ee6No frontend code is changed.