feat(inbox): approval-item expiry (TTL) for all approval kinds (#622) - #637
Open
cagdasyurekli wants to merge 2 commits into
Open
cagdasyurekli wants to merge 2 commits into
cagdasyurekli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Changes
Add configurable approval TTLs and expired outcomes across the Inbox, manager and engine. Expired requests reject late approval and unblock suspended turns with a visible expiration result. Waiting for an already-expired item no longer reacquires the non-reentrant store lock. Plan-mode hard denials initialize the approval outcome and return a denial instead of raising an unbound-variable exception.
Verification
pytest tests -q— 1,964 passed, 1 skipped (macOS, Python 3.14).