Skip to content

fix: QA fallback summary drops non-fatal harness error context - #3

Open
andrewwhitecdw wants to merge 2 commits into
mainfrom
codequality/coding-qa-fallback-summary-drops-non-fatal
Open

fix: QA fallback summary drops non-fatal harness error context#3
andrewwhitecdw wants to merge 2 commits into
mainfrom
codequality/coding-qa-fallback-summary-drops-non-fatal

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Owner

This PR addresses the following issue in go/internal/roles/coding/coding.go: QA fallback summary drops non-fatal harness error context.

Changes

  • go/internal/roles/coding/coding.go: QA fallback summary drops non-fatal harness error context.

Details

--- a/go/internal/roles/coding/coding.go
+++ b/go/internal/roles/coding/coding.go
@@ -1,7 +1,11 @@
-	return &schemas.QAResult{
-		Passed:       false,
-		Summary:      fmt.Sprintf("QA agent failed for %s", issueName),
-		TestFailures: []map[string]any{},
-		CoverageGaps: []string{},
-		IterationID:  in.IterationID,
-	}, nil
+	summary := fmt.Sprintf("QA agent failed for %s", issueName)
+	if hErr != nil {
+		summary += ": " + hErr.Error()
+	}
+	return &schemas.QAResult{
+		Passed:       false,
+		Summary:      summary,
+		TestFailures: []map[string]any{},
+		CoverageGaps: []string{},
+		IterationID:  in.IterationID,
+	}, nil

Tests

Let me know if you want tests added for this fix or not.

AbirAbbas and others added 2 commits July 31, 2026 22:23
…ude/sonnet (Agent-Field#120)

Direct reasoner calls hard-coded ai_provider=claude and model=sonnet,
so on an OpenRouter-only deployment (the common cloud setup) every
direct role call tried the claude harness and failed instantly - even
though config.DefaultRuntime() already auto-selects open_code there and
the orchestrators already resolve properly. Resolve absent runtime and
model inputs at call time through the existing config cascade
(SWE_DEFAULT_RUNTIME, tier env vars, OpenRouter auto-default); explicit
input values are untouched. Adds config.DefaultRoleModel backed by
ResolveRuntimeModels/RoleToTier so coding and gitops roles pick their
tier-correct model.

Verified live on a Railway control plane where run_product_manager
failed in 500ms with the old defaults and succeeded via opencode with
provider overrides.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants