[BUGFIX] Replace usage of UnifiedDiffOutputBuilder with StrictUnifiedDiffOutputBuilder#409
Draft
alexanderschnitzler wants to merge 1 commit into
Draft
Conversation
alexanderschnitzler
force-pushed
the
fix/diff-output-builder
branch
from
0b21990 to
95027d7
Compare
…DiffOutputBuilder Resolves: andreaswolf#408
alexanderschnitzler
force-pushed
the
fix/diff-output-builder
branch
from
95027d7 to
fe22f6d
Compare
Contributor
Author
|
@andreaswolf @simonschaufi Maybe someone of you can take a deeper look sometime. I am not quite sure how fractor works in detail. It seems that replacing the |
Collaborator
|
What I would do is to check how Rector fixed this issue as most of the Fractor code is almost a 1:1 copy of Rector |
| private ColorConsoleDiffFormatter $colorConsoleDiffFormatter | ||
| ) { | ||
| $unifiedDiffOutputBuilder = new UnifiedDiffOutputBuilder(); | ||
| $unifiedDiffOutputBuilder = new StrictUnifiedDiffOutputBuilder([ |
Collaborator
There was a problem hiding this comment.
Have a look at the DefaultDiffer from Rector (in the rector-src repo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #408