Conversation
Owner
Author
|
will continue on this work next week. have to refocus on other things for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #30.
Heavily uses gofmt as inspiration for code. A couple things worth noting:
d2 fmtis only supported in version v0.1.4 onward.oss.tesseractorigin is only available tov0.1.2afaik. Brew is also behindv0.1.4. The point being, it is very likely that a lot of people will have unsupported versions.Handling needs to be made with care that the proper messaging is provided to users that don't have the correct version of d2.
Additionally, it might make sense to add an additional feature to the repo, which is an upgrade command to upgrade d2.
#38