wip: first stab at separating out all phy related things to phy thread#47
Closed
wip: first stab at separating out all phy related things to phy thread#47
Conversation
Claudes summary of the changes: stm32h7_eth_init — now only does clock/GPIO/SYSCFG setup, stores phyrst/mode/flags into the struct, and starts the PHY thread. stm32h7_phy_thread — now begins with the PHY reset pulse, then driver_probe. On failure it loops forever (satisfying __attribute__((noreturn))). On success it calls stm32h7_eth_mac_init, then enters the link-polling loop. stm32h7_eth_mac_init (new) — contains everything that used to follow the probe in stm32h7_eth_init: MAC address, ring alloc, soft reset, PTP init (using se->se_flags), DMA config, ether_netif_init, and IRQ enable. eriang: changed udelay to usleep in thread. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eriang
force-pushed
the
eriang/stm32-phy-fix
branch
from
6c75712 to
34a6443
Compare
Collaborator
Author
|
@andoma will implement other solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claudes summary of the changes:
stm32h7_eth_init — now only does clock/GPIO/SYSCFG setup, stores phyrst/mode/flags into the struct, and starts the PHY thread.
stm32h7_phy_thread — now begins with the PHY reset pulse, then driver_probe. On failure it loops forever (satisfying attribute((noreturn))). On success it calls stm32h7_eth_mac_init, then enters the link-polling loop.
stm32h7_eth_mac_init (new) — contains everything that used to follow the probe in stm32h7_eth_init: MAC address, ring alloc, soft reset, PTP init (using se->se_flags), DMA config, ether_netif_init, and IRQ enable.