fix: resolve indexer and secret redaction issues - #1434
Open
damiedee96 wants to merge 1 commit into
Open
damiedee96 wants to merge 1 commit into
damiedee96 wants to merge 1 commit into
Conversation
|
@damiedee96 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues across the AI agent and indexer services:
Fixes #1425 by making seed-phrase redaction case-insensitive, preventing capitalized recovery phrases from reaching audit logs.
Fixes #1426 by adding dead-letter idempotency with a unique database constraint and ON CONFLICT DO NOTHING.
Fixes #1427 by advancing the backfill cursor for all fetched events, including those outside the requested range.
Fixes #1428 by validating contract addresses using checksummed Stellar C-address StrKeys instead of shape-only validation.
Testing
AI-agent redaction tests
Indexer backfill tests
Indexer contract-address validation tests
Rust formatting check
Rust Clippy with warnings denied
Migration lint
Prettier check
Full repository pre-push checks
Closes #1425 , Closes #1426 , Closes #1427 , Closes #1428